-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Pr05 Typescript Migration #18: Migrate client/modules/About & client/modules/Legal
#3702
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pr05 Typescript Migration #18: Migrate client/modules/About & client/modules/Legal
#3702
Conversation
client/modules/About & client/modules/Legal
khanniie
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great!! thank you!
raclim
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so much @clairep94 and @khanniie! This is awesome and I really appreciate the video giving a preview into your process! Sorry that it took a while to get to this—I'll get this one and #19 in, and might take a moment to review #20 and #21!
Picking off easy wins in the
client/modulesfolderCHECKING.LEGAL.MIGRATION.mov
Changes:
client/modules/Aboutclient/modules/LegalNotes:
Cherry-picked relevant commits from the giant rough-work PR here for easier review
I have verified that this pull request:
npm run lint)npm run test)developbranch.Fixes #123