Skip to content

Conversation

@khanniie
Copy link
Member

@khanniie khanniie commented Jan 28, 2025

Fixes the editor accessibility issue that appears to happen on the develop branch:

 FAIL  client/modules/IDE/components/EditorAccessibility.unit.test.jsx
  ● <EditorAccessibility /> › renders empty message with no lines

    TestingLibraryElementError: Unable to find an accessible element with the role "listitem" and description "There are no lint messages"

Changes: The issue (not sure when it was first introduced) is that the "there are no lint messages" list item element does not have an aria-describedby attribute so the original method of fetching by role and description does not actually detect what it's looking for. This switches the test to look for the string instead.

I have verified that this pull request:

  • has no linting errors (npm run lint)
  • has no test errors (npm run test)
  • is from a uniquely-named feature branch and is up to date with the develop branch.
  • is descriptively named and links to an issue number, i.e. Fixes #123

@release-com
Copy link

release-com bot commented Jan 28, 2025

Release Environments

This Environment is provided by Release, learn more!
To see the status of the Environment click on Environment Status below.

🔧Environment Status : https://app.release.com/public/Processing%20Foundation/env-a55ba451c5

@raclim
Copy link
Collaborator

raclim commented Mar 6, 2025

Hi! I'm going to close this for now just for organization, but feel free to revisit or reopen this if it feels like something we should come back to!

@raclim raclim closed this Mar 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants