Skip to content

Conversation

@khanniie
Copy link
Member

Changes: As part of the editor conversion, we are splitting up the editor file into smaller pieces first. This branches the hint autocomplete related functionality into a new file called hinter.js.

I have verified that this pull request:

  • has no linting errors (npm run lint)
  • has no test errors (npm run test) (I think the test error is preexisting)
  • is from a uniquely-named feature branch and is up to date with the develop branch.
  • is descriptively named and links to an issue number, i.e. Fixes #123

@khanniie khanniie requested a review from raclim January 28, 2025 06:03
@release-com
Copy link

release-com bot commented Jan 28, 2025

Release Environments

This Environment is provided by Release, learn more!
To see the status of the Environment click on Environment Status below.

🔧Environment Status : https://app.release.com/public/Processing%20Foundation/env-0e7a393ce1

Copy link
Collaborator

@raclim raclim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for starting the work on this! I think besides the error in the hinter.js file, this overall looks great to me!

@khanniie khanniie requested a review from raclim January 31, 2025 16:54
Copy link
Collaborator

@raclim raclim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! This looks good to me! :)

@khanniie khanniie merged commit 4d9b05f into connie-develop Jan 31, 2025
4 checks passed
@raclim raclim deleted the connie-editor-conversion-hint-file branch April 28, 2025 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants