Skip to content

Fix The Freeze Hinter #3252 #3299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Feb 12, 2025
Merged

Fix The Freeze Hinter #3252 #3299

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
7346e51
Fix The Freeze Hinter #3252
Jatin24062005 Dec 9, 2024
175122e
Merge branch 'develop' into JATIN/#3252
raclim Feb 6, 2025
ad1be89
Update package.json
Jatin24062005 Feb 7, 2025
76a8399
Update package-lock.json
Jatin24062005 Feb 7, 2025
a70d205
Remove package-lock.json
Jatin24062005 Feb 7, 2025
ff1295a
fix: remove prior changes, add extra key option for shift-tab
raclim Feb 11, 2025
28223b7
Merge branch 'develop' into JATIN/#3252
raclim Feb 12, 2025
3626fc3
Revert "Remove package-lock.json"
raclim Feb 12, 2025
95f1cb7
fix: merge conflicts in package-lock.json
raclim Feb 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions client/modules/IDE/components/show-hint.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,14 @@
this.cm.getLine(this.startPos.line).length -
this.cm.getSelection().length;

// keydown event for handling Escape key press
var self = this;

cm.getWrapperElement().addEventListener('keydown', function (event) {
self.handleKeyPress(self.cm, event);
});


if (this.options.updateOnCursorActivity) {
var self = this;
cm.on(
Expand Down Expand Up @@ -159,6 +167,14 @@
}
},

handleKeyPress: function (cm, event) {
if (event.key === 'Escape' || event.keyCode === 27) {
// Close the completion component
this.close();
event.preventDefault(); // Prevent default Escape key behavior
}
},

update: function (first) {
if (this.tick == null) return;
var self = this,
Expand Down
Loading