Skip to content

[Refactor] 경매 상세 response dto 재구화 #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dpwl0974 merged 4 commits into from
Dec 10, 2025
Merged

[Refactor] 경매 상세 response dto 재구화 #23

dpwl0974 merged 4 commits into from
Dec 10, 2025

Conversation

@dpwl0974
Copy link
Collaborator

@dpwl0974 dpwl0974 commented Dec 10, 2025

📌 관련 이슈

📝 변경 사항

AS-IS

  • null 타입이 불가능한 타입
  • 엔티티와 일정하지 않은 타입입
  • 타입 반환이 아닌 예시 반환

TO-BE

  • 엔티티에 맞게, Null 타입 반환이 가능하게 타입 변경
  • 불필요한 필드 삭제
  • 타입을 반환하도록 재구조화

🔍 테스트

  • 테스트 코드 작성
  • API 테스트
  • 로컬 테스트

📸 스크린샷

// UI 변경사항이 있는 경우

✅ 체크리스트

  • main/develop 브랜치가 아닌 feature 브랜치에서 작성했나요?
  • 코딩 컨벤션을 준수했나요?
  • 불필요한 코드는 제거했나요?
  • 주석은 충분히 작성했나요?
  • 테스트는 완료했나요?

🙋‍♂️ 리뷰어에게

별 거 아닌 부분입니다 !

@dpwl0974 dpwl0974 self-assigned this Dec 10, 2025
@dpwl0974 dpwl0974 added the ♻️ refactor 리팩토링입니다. 전후로 기능 변경이 없어야 합니다. label Dec 10, 2025
zoooooz2
zoooooz2 approved these changes Dec 10, 2025
View reviewed changes
Copy link
Collaborator

@zoooooz2 zoooooz2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

확인했습니다! 고생하셨습니다~!

hodakrer
hodakrer approved these changes Dec 10, 2025
View reviewed changes
Copy link
Collaborator

@hodakrer hodakrer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

swagger에 가까운 내용이었군요!

@github-actions
Copy link

github-actions bot commented Dec 10, 2025

Unit Test Results

6 tests   6 ✔️  0s ⏱️
3 suites  0 💤
3 files    0 ❌

Results for commit d23bd97.

@dpwl0974 dpwl0974 merged commit 2fbd2d2 into develop Dec 10, 2025
3 checks passed
@dbghwns123 dbghwns123 deleted the refactor/auction-response-dto branch December 10, 2025 05:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zoooooz2 zoooooz2 zoooooz2 approved these changes

@hodakrer hodakrer hodakrer approved these changes

Assignees

@dpwl0974 dpwl0974

Labels

♻️ refactor 리팩토링입니다. 전후로 기능 변경이 없어야 합니다.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Refactor] 경매 응답 DTO 재구조화

4 participants

@dpwl0974 @zoooooz2 @hodakrer