Skip to content

Conversation

@loseminho
Copy link
Collaborator

๐Ÿ“Œ ๊ฐœ์š”

VISITOR(๋ฉค๋ฒ„ ๋ณด๋‹ค ๋‚ฎ์€ ์ฐธ์—ฌ์ž) -> Redis์—๋งŒ ์ €์žฅํ•˜๊ณ  DB์— ์ €์žฅ์€ MEMBER ๋“ฑ๊ธ‰ ์ด์ƒ๋ถ€ํ„ฐ.
์„ฑ๋Šฅ๊ฐœ์„  :

  • 100๋ช…์ด ๋‚œ๋Œ€ ์—†์ด ๋“ค์–ด์™”๋‹ค ๋‚˜๊ฐ“๋‹ค ํ•ด๋„ DB INSERT์ ˆ์ด ๋ฐœ์ƒ ์•ˆํ•จ
  • ์กฐํšŒ N+1 ๋ฌธ์ œ ํ•ด๊ฒฐ : IN ์ ˆ๋กœ ์ผ๊ด„ ์กฐํšŒ ํ•˜๋„๋ก

๐Ÿ”จ ์ž‘์—… ๋‚ด์šฉ

๊ถŒํ•œ์— ๋Œ€ํ•œ ๋กœ์ง ์ˆ˜์ •

  • VISITOR DB ์ €์žฅ ์ œ๊ฑฐ
  • ํ†ตํ•ฉ ์—ญํ•  ๋ณ€๊ฒฝ API ์ถ”๊ฐ€ - PUT /api/rooms/{roomId}/members/{userId}/role
    • ๋ชจ๋“  ์œ ์ €์— ๋Œ€ํ•ด์„œ ๋ฐฉ์žฅ์ด ๊ถŒํ•œ ๋ณ€๊ฒฝ ๊ฐ€๋Šฅ,
    • ๋ฐฉ์žฅ์ด ๋‹ค๋ฅธ ์‚ฌ๋žŒ์—๊ฒŒ ๋ฐฉ์žฅ์„ ๋ถ€์—ฌ ์‹œ ์ž๋™์œผ๋กœ MEMBER๋กœ ๊ฐ•๋“ฑ
    • ๋ณธ์ธ ์—ญํ•  ๋ณ€๊ฒฝ ๋ถˆ๊ฐ€
  • ๋ฐฉ์žฅ์ด ํ‡ด์žฅ ํ•ด๋„ ๋ฐฉ ์œ ์ง€ ๋˜๋„๋ก ๋ณ€๊ฒฝ (์ฐธ์—ฌ์ž 0๋ช…์ด์–ด๋„, ๋ฐฉ์žฅ ์žฌ์ž…์žฅ ์‹œ ๋ฐฉ์žฅ ๊ถŒํ•œ ์œ ์ง€, ๋ฐฉ ์ข…๋ฃŒ๋Š” ๋ฐฉ์žฅ๋งŒ ๋ช…์‹œ์ ์œผ๋กœ ๊ฐ€๋Šฅ)
  • ํ•ด๋‹น ๋กœ์ง ๋ณ€๊ฒฝ์— ๋Œ€ํ•œ ์—๋Ÿฌ์ฝ”๋“œ ์ž‘์„ฑ

+ ์ถ”๊ฐ€๋œ ์‚ฌํ•ญ

  • RommServiceTest.java ํŒŒ์ผ ์ˆ˜์ •
    • Mock ์ถ”๊ฐ€ ํ›„ ์ฐธ์—ฌ์™€ ์กฐํšŒ, ํ‡ด์žฅ ๊ฐ•ํ‡ด์— ๋Œ€ํ•ด Redis๋กœ ํ™•์ธ
  • ๊ถŒํ•œ์— ๋Œ€ํ•œ ์—๋Ÿฌ์ฝ”๋“œ ์—…๋ฐ์ดํŠธ
    • ROOM_013, ROOM_014

๐Ÿ”— ๊ด€๋ จ ์ด์Šˆ

Closes #146


๐Ÿ“ ์ฐธ๊ณ  ์‚ฌํ•ญ


โœ… ์ฒดํฌ๋ฆฌ์ŠคํŠธ

  • ๊ธฐ๋Šฅ ๋™์ž‘ ํ™•์ธ
  • ํ…Œ์ŠคํŠธ ์ฝ”๋“œ ์ž‘์„ฑ
  • ๋ฌธ์„œ/์ฃผ์„ ์ถ”๊ฐ€ ๋ฐ ์ตœ์‹ ํ™”

@github-actions github-actions bot changed the title Refactor/146 Refactor/146 (#146) Oct 3, 2025
@loseminho loseminho merged commit a89df69 into dev Oct 3, 2025
2 checks passed
@github-actions github-actions bot deleted the refactor/146 branch October 3, 2025 12:52
namgigun pushed a commit that referenced this pull request Oct 4, 2025
* refactor: ์Šค๋”ํ‹ฐ๋ฃธ ๊ถŒํ•œ์— ๋Œ€ํ•œ ๋กœ์ง ๊ฐœ์„ 

* fix: ci์—์„œ ํ†ต๊ณผ ๋ชปํ•œ ํ…Œ์ŠคํŠธ์ฝ”๋“œ ์ˆ˜์ •
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants