Skip to content

Add types to the Match function #422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tim-we wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Add types to the Match function #422

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ab7fdf9
Add types to Match function
tim-we Feb 26, 2022
edd80e3
Remove unused import
tim-we Feb 26, 2022
418deb1
Remove unused import
tim-we Feb 26, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions match/index.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,18 @@
import * as preact from 'preact';

import { Link as StaticLink, RoutableProps } from '..';
import { RoutableProps } from '..';

export class Match extends preact.Component<RoutableProps, {}> {
type MatchInfo = {
url: string;
path: string;
matches: Record<string, string>;
};

type MatchProps = RoutableProps & {
children: (info: MatchInfo) => preact.VNode;
};

export class Match extends preact.Component<MatchProps, {}> {
render(): preact.VNode;
}

Expand Down
2 changes: 1 addition & 1 deletion test/match.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { h } from 'preact';
import { Link, RoutableProps } from '../';
import { Link } from '../';
import { Match } from '../match';

function ChildComponent({}: {}) {
Expand Down