Timestamps: Emit in UTC #17
Merged
+10
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rentacookie
approved these changes
Dec 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the MySQL binlog stream, timestamps are encoded as seconds since the unix epoch. This means that the library will have to extract individual fields to represent the value if it should be emitted as a string, for which it uses
new Date()anddate.getHours().Since methods like
getHours()are used, this library effectively unconditionally uses the local time zone. This PR changes the logic to use UTC instead. Ideally, the timezone should respect the connection's timezone, but that isn't possible without the temporal API which is not yet available. Since we're always using UTC in the PowerSync service, this ensures the values this package emits are in the format we expect.(This is technically covered by existing tests, they just passed because GH actions runs in UTC)