port-changes - frozen columns #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odeddoek
reviewed
Jan 28, 2025
| --rdg-selection-color: #66afe9; | ||
| --rdg-font-size: 14px; | ||
| --rdg-cell-frozen-box-shadow: 2px 0 5px -2px rgba(136, 136, 136, 0.3); | ||
| --rdg-cell-right-frozen-box-shadow: -2px 0 5px -2px rgba(136, 136, 136, 0.3); |
There was a problem hiding this comment.
Just check if we can override it in the frontend app, so we can apply theming if needed (needed for dark theme already)
Collaborator
Author
There was a problem hiding this comment.
I've checked and we can, you can take a look at table.css
odeddoek
reviewed
Jan 28, 2025
src/utils/domUtils.ts
Outdated
|
|
||
| export function scrollIntoView(element: Maybe<Element>) { | ||
| element?.scrollIntoView({ inline: 'nearest', block: 'nearest' }); | ||
| // element?.scrollIntoView({ inline: 'center', block: 'nearest' }); |
odeddoek
reviewed
Jan 28, 2025
src/HeaderCell.tsx
Outdated
| &:hover { | ||
| background: var(--rdg-selection-color); | ||
| padding: 5px 0; |
There was a problem hiding this comment.
Let's do duplication of 2/4 (so let's use 4px or 6px here)
odeddoek
reviewed
Feb 2, 2025
src/types.ts
Outdated
| renderCheckbox?: Maybe<(props: RenderCheckboxProps) => ReactNode>; | ||
| renderRow?: Maybe<(key: Key, props: RenderRowProps<TRow, TSummaryRow>) => ReactNode>; | ||
| renderSortStatus?: Maybe<(props: RenderSortStatusProps) => ReactNode>; | ||
| renderCell?: Maybe<(key: Key, props: CellRendererProps<TRow, TSummaryRow>) => ReactNode>; |
odeddoek
reviewed
Feb 2, 2025
| /** Render function used to render the content of the column's header cell */ | ||
| readonly renderHeaderCell?: Maybe<(props: RenderHeaderCellProps<TRow, TSummaryRow>) => ReactNode>; | ||
| /** Render function used to render the content of cells */ | ||
| readonly renderCell?: Maybe<(props: RenderCellProps<TRow, TSummaryRow>) => ReactNode>; |
odeddoek
approved these changes
Feb 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.