Skip to content

Fix (Uninstall) - Restore mini-dashboard delete function #3621

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Rom1-B merged 5 commits into from
Nov 6, 2025
Merged

Fix (Uninstall) - Restore mini-dashboard delete function #3621

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
f6f57ca
Fix (Uninstall) - Restore mini-dashboard delete function
RomainLvr Nov 5, 2025
2d04acd
Fix phpstan
RomainLvr Nov 5, 2025
4465f41
Fix phpstan
RomainLvr Nov 5, 2025
48c418a
Update src/Install.php
RomainLvr Nov 6, 2025
8861615
Delete phpunit.xml to avoid CI errors
RomainLvr Nov 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions phpunit.xml
View file
Open in desktop

This file was deleted.

9 changes: 9 additions & 0 deletions src/Install.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -491,6 +491,14 @@ protected function deleteTables() {
$displayPreference->deleteByCriteria(['itemtype' => 'PluginFormcreatorIssue']);
}

protected function deleteMiniDashboard(): bool {
$dashboard = new Dashboard();

return $dashboard->deleteByCriteria([
'key' => 'plugin_formcreator_issue_counters'
]);
}

/**
* http://stackoverflow.com/questions/834303/startswith-and-endswith-functions-in-php
* @param string $haystack
Expand All @@ -508,6 +516,7 @@ public function uninstall() {
$this->deleteTicketRelation();
$this->deleteTables();
$this->deleteNotifications();
$this->deleteMiniDashboard();

$config = new Config();
$config->deleteByCriteria(['context' => 'formcreator']);
Expand Down