Library updates for initialize and template flag handling #37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o handle a template and initialize flag
shawnawsu
changed the title
bbujisic
suggested changes
Aug 30, 2019
shawnawsu
changed the title
This was referenced Sep 12, 2019
pjcdawkins
reviewed
Sep 18, 2019
| */ | ||
| public function getCatalog() | ||
| { | ||
| return Catalog::create([], $this->accountsEndpoint . 'setup/catalog', $this->getConnector()->getClient()); |
Collaborator
There was a problem hiding this comment.
Pretty much the same objections as #39 - the catalog isn't a thing that lists items on GET /catalog, lets me GET a consitutuent item in GET/catalog/:id, etc, DELETE/PUT/PATCH to modify, POST to add to the list, etc, it's not a RESTful resource, so reusing the Resource model here is at least a bit awkward.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This contains the updates that are required by platformsh/legacy-cli#829.