Skip to content

Prevent global side-effect in Bug13813IntegrationTest #4566

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 19, 2025
Merged

Prevent global side-effect in Bug13813IntegrationTest #4566

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
80aa859
Prevent global side-effect in Bug13813IntegrationTest
staabm Nov 19, 2025
9025731
wrap in try/finally
staabm Nov 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions tests/PHPStan/Analyser/Bug13813IntegrationTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,8 @@ class Bug13813IntegrationTest extends PHPStanTestCase

public function testBug13813(): void
{
$oldReporting = error_reporting();

error_reporting(E_ALL);
$analyzerResult = $this->runAnalyse([
__DIR__ . '/data/bug-13813.php',
Expand Down Expand Up @@ -44,6 +46,8 @@ public function testBug13813(): void
$analyzerResult->getAllPhpErrors()[1]->getMessage(),
);
}

error_reporting($oldReporting);
Copy link
Member

@ondrejmirtes ondrejmirtes Nov 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the:

		$analyzerResult = $this->runAnalyse([
			__DIR__ . '/data/bug-13813.php',
			__DIR__ . '/Bug13813Rule.php',
		]);

should be wrapped in a try-finally block and the restore be done there.

}

/**
Expand Down
Loading