Ignore ApiInstanceofTypeRule in SimultaneousTypeTraverser #4452
+22
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VincentLanglet
force-pushed
the
traverser
branch
2 times, most recently
from
fe4f9f5 to
a8616d5
Compare
VincentLanglet
force-pushed
the
traverser
branch
from
a8616d5 to
782cdc9
Compare
Member
|
I'm not sure about this one yet. It remains to be seen what's the right implementation for a callback in SimultaneousTypeTraverser. Because the implementation of traverseSimultaneously in IntersectionType is not obvious, it might mean that doing I'll keep this open, we'll see. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed for #4210