Add regression test

[herndlm]

For the loop/count case of phpstan/phpstan#1311

[herndlm]

this is still here in a different format, because the test basically has strict rules enabled and the phpdoc is essentially wrong. not fully sure how to deal with this. see also
https://phpstan.org/r/29982739-327a-494d-bc97-06021030576b vs https://phpstan.org/r/a780f206-b942-4d5e-8be2-e3a79a911964

[ondrejmirtes]

I don't get it. How does this test have strict-rules enabled? And which parameter from strict-rules is causing this error to appear?

[herndlm]

tbh I was hoping you would tell me 😅 looks like it's coming from the $strictTypes here:

phpstan-src/src/Type/StringType.php

Lines 128 to 130 in c8833df

	if ($thatClassNames === [] || $strictTypes) {
	return AcceptsResult::createNo();
	}

the string array values are not accepting the int values.

but not sure how that is related to strict-rules..

[herndlm]

aha on the playground the treatPhpDocTypesAsCertain is also somehow involved apparently. I obviously did not invest carefully now but it's confusing :)

[ondrejmirtes]

My guess is one of the pollute options set to false, that would explain the playground, but it doesn't explain the rule test.

[herndlm]

you were right, setting polluteScopeWithLoopInitialAssignments to true makes the error go away in the test (it is false there). in general, by default it is true and strict-rules sets this to false in the playground which makes the error appear.

[ondrejmirtes]

I changed it (it surprised me), so please rebase and update this branch 1b56b0c

[herndlm]

done. looking good now 👍

[ondrejmirtes]

Thank you.