Ignore negative keys on checking whether a ConstantArray is a list

[watasuke102]

In ConstantArrayTypeBuilder, setOffsetValueType() uses ConstantIntegerType of offsetType for checking whether a ConstantArray is a list, but doesn't check whether it is positive. Because of that, a ConstantArray that has negative integer keys is treated as list.

This PR resolves phpstan/phpstan#12708.

[phpstan-bot]

This pull request has been marked as ready for review.

[ondrejmirtes]

A similar fix needs to be done in ArrayType::isList() - see https://phpstan.org/r/47372278-5264-4f01-a12c-dce00a50539f

[ondrejmirtes]

Sorry, I'm wrong.

[ondrejmirtes]

Disregard my review there.

[ondrejmirtes]

Please only check this review. Thanks.

[watasuke102]

Oh I requested review by mistake, sorry

[watasuke102]

It's ready for review, thank you!

[ondrejmirtes]

Thank you.

[zonuexe]

Probably not a problem with ArrayType, but I found a problem with ConstantArrayType::isList() by modifying Ondřej's case.

https://phpstan.org/r/78b134e0-88b0-4bbf-be11-032bc267650c

[ondrejmirtes]

@zonuexe Array shapes are not currently sealed by default. The most upvoted feature request about it is here on GitHub.

[zonuexe]

This problem is also related to sealed array, but that alone doesn't prevent input like [1 => 'x', 0 => 'y'], so we might need a type like array{0: string, 1: string}&list

[ondrejmirtes]

I get it, it's complicated 😊 Maybe we could enforce the order of keys along with true sealed-ness of arrays.