Enhancement: Run vimeo/psalm on GitHub Actions

[localheinz]

This pull request

• runs a static code analysis with vimeo/psalm on GitHub Actions

Follows #559.

[kamil-tekiela]

Given that we have very little test coverage (and are currently unable to name it), using a tool to run a static code analysis can improve our confidence in the changes we make.

That would help, but not by much. For me the biggest problem in this project is the interdependency with other repos and who knows what else. It's a jungle. There are scripts that call other scripts, execute functions, include files and more. This makes it difficult to refactor anything, because we don't know what has an impact on what.

[github-actions]

🚀 Commit db5ec41 Deployed on https://web-php-pr-892.preview.thephp.foundation

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (master@42e335e). Click here to learn what that means.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@           Coverage Diff            @@
##             master    #892   +/-   ##
========================================
  Coverage          ?   0.14%           
  Complexity        ?      45           
========================================
  Files             ?      49           
  Lines             ?   43151           
  Branches          ?       0           
========================================
  Hits              ?      64           
  Misses            ?   43087           
  Partials          ?       0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[pronskiy]

@localheinz, just checking whether you are interested in updating this PR?

Does it make sense to switch to PHPStan? @staabm, would you be interested in picking this up?

[staabm]

Does it make sense to switch to PHPStan?

I am biased - but from my PoV PHPStan seems to have a more vital ecosystem atm. psalm kind of stagnated in the recent months, so this might not be a good option to introduce.

if the dev-team of this repo is interessted in static analysis analysis I can give it a go.
introducing such tooling only will have a benefit if the people contributing to this repo want it though.

[pronskiy]

if the dev-team of this repo is interessted in static analysis analysis I can give it a go

I’m all for it. @saundefined, @sy-records, @TimWolla, @cmb69, are you ok with this?

[TimWolla]

No opinion on this. I'm not really maintaining the website (I just care about the contents).