Skip to content

Improve TypeError messages for non-numeric/empty strings in coercions; Closes #20632 #20639

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 15 commits into
base: master
Choose a base branch
from
+1,222 −1,156
Open

Improve TypeError messages for non-numeric/empty strings in coercions; Closes #20632 #20639

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
422b0c8
Improve TypeError messages for non-numeric/empty strings in coercions
rizwan3d Dec 4, 2025
277f1c6
Update: Unit Test to #20632
rizwan3d Dec 4, 2025
37e97db
Update: Unit Test to php#20632
rizwan3d Dec 4, 2025
e7e12e3
Update: Unit Test to php#20632
rizwan3d Dec 4, 2025
e0175a9
Update: Unit Test to php#20632
rizwan3d Dec 4, 2025
1a0c4dd
Update: Unit Test to php#20632
rizwan3d Dec 4, 2025
7883185
Update Zend/zend_API.c
rizwan3d Dec 4, 2025
dd23d6a
Update: Unit Test to php#20632
rizwan3d Dec 4, 2025
f586c76
Update: Unit Test to php#20632
rizwan3d Dec 4, 2025
e8dadd5
Update: Unit Test to php#20632
rizwan3d Dec 4, 2025
7ec7d03
Fix 'namaric' typo in zend_zval_numeric_string_value_name() and updat…
rizwan3d Dec 4, 2025
1b9aaac
Use ZVAL_DEREF() in zend_zval_numeric_string_value_name()
rizwan3d Dec 4, 2025
9152f3b
Use is_numeric_string_ex() to avoid mislabelling numeric strings as n…
rizwan3d Dec 4, 2025
9f8a5ca
Use is_numeric_string_ex() to avoid mislabelling numeric strings as n…
rizwan3d Dec 4, 2025
f18f611
Update: Unit Test to php#20632
rizwan3d Dec 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Zend/tests/add_006.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,13 +45,13 @@ var_dump($c);
echo "Done\n";
?>
--EXPECTF--
Unsupported operand types: int + string
Unsupported operand types: int + non-numeric string

Warning: A non-numeric value encountered in %s on line %d
int(951858)
int(48550510)
float(75661.68)
Unsupported operand types: string + int
Unsupported operand types: non-numeric string + int

Warning: A non-numeric value encountered in %s on line %d
int(951858)
Expand Down
4 changes: 2 additions & 2 deletions Zend/tests/add_007.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,9 +19,9 @@ var_dump($c);
echo "Done\n";
?>
--EXPECTF--
Exception: Unsupported operand types: array + string
Exception: Unsupported operand types: array + non-numeric string

Fatal error: Uncaught TypeError: Unsupported operand types: array + string in %s:%d
Fatal error: Uncaught TypeError: Unsupported operand types: array + non-numeric string in %s:%d
Stack trace:
#0 {main}
thrown in %s on line %d
4 changes: 2 additions & 2 deletions Zend/tests/arrow_functions/006.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ try {
--EXPECTF--
int(2)
int(10)
{closure:%s:%d}(): Argument #1 ($x) must be of type int, string given, called in %s on line %d
{closure:%s:%d}(): Argument #1 ($x) must be of type int, non-numeric string given, called in %s on line %d
array(3) {
[0]=>
int(20)
Expand All @@ -41,4 +41,4 @@ array(3) {
[2]=>
int(30)
}
{closure:%s:%d}(): Argument #2 must be of type ?int, string given, called in %s on line %d
{closure:%s:%d}(): Argument #2 must be of type ?int, non-numeric string given, called in %s on line %d
16 changes: 8 additions & 8 deletions Zend/tests/assign_op_type_error.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,11 +47,11 @@ try {

?>
--EXPECT--
Unsupported operand types: array + string
Unsupported operand types: array - string
Unsupported operand types: array * string
Unsupported operand types: array / string
Unsupported operand types: array ** string
Unsupported operand types: array % string
Unsupported operand types: array << string
Unsupported operand types: array >> string
Unsupported operand types: array + non-numeric string
Unsupported operand types: array - non-numeric string
Unsupported operand types: array * non-numeric string
Unsupported operand types: array / non-numeric string
Unsupported operand types: array ** non-numeric string
Unsupported operand types: array % non-numeric string
Unsupported operand types: array << non-numeric string
Unsupported operand types: array >> non-numeric string
2 changes: 1 addition & 1 deletion Zend/tests/attributes/030_strict_types.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ object(MyAttribute)#1 (1) {
int(42)
}

Fatal error: Uncaught TypeError: MyAttribute::__construct(): Argument #1 ($value) must be of type int, string given, called in %s030_strict_types.inc on line 4 and defined in %s030_strict_types.php:5
Fatal error: Uncaught TypeError: MyAttribute::__construct(): Argument #1 ($value) must be of type int, non-numeric string given, called in %s030_strict_types.inc on line 4 and defined in %s030_strict_types.php:5
Stack trace:
#0 %s030_strict_types.inc(4): MyAttribute->__construct('42')
#1 %s(%d): ReflectionAttribute->newInstance()
Expand Down
2 changes: 1 addition & 1 deletion Zend/tests/exceptions/exception_017.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ Error: Cannot call abstract method C::foo() in %s:%d
Stack trace:
#0 {main}

TypeError: foo(): Argument #1 ($x) must be of type callable, string given, called in %s:%d
TypeError: foo(): Argument #1 ($x) must be of type callable, non-numeric string given, called in %s:%d
Stack trace:
#0 %s(%d): foo('C::foo')
#1 {main}
Expand Down
2 changes: 1 addition & 1 deletion Zend/tests/fibers/start-arguments.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ $fiber->start('test');
--EXPECTF--
int(1)

Fatal error: Uncaught TypeError: {closure:%s:%d}(): Argument #1 ($x) must be of type int, string given in %s:%d
Fatal error: Uncaught TypeError: {closure:%s:%d}(): Argument #1 ($x) must be of type int, non-numeric string given in %s:%d
Stack trace:
#0 [internal function]: {closure:%s:%d}('test')
#1 %sstart-arguments.php(%d): Fiber->start('test')
Expand Down
2 changes: 1 addition & 1 deletion Zend/tests/first_class_callable/first_class_callable_015.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,4 +21,4 @@ try {
?>
--EXPECTF--
int(42)
test(): Argument #1 ($i) must be of type int, string given, called in %s on line %d
test(): Argument #1 ($i) must be of type int, non-numeric string given, called in %s on line %d
2 changes: 1 addition & 1 deletion Zend/tests/function_arguments/argument_count_incorrect_userland_strict.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,6 @@ Too few arguments to function bar(), 1 passed in %s and exactly 2 expected
ArgumentCountError
Too few arguments to function bat(), 1 passed in %s and exactly 2 expected
TypeError
bat(): Argument #1 ($foo) must be of type int, string given, called in %s on line %d
bat(): Argument #1 ($foo) must be of type int, non-numeric string given, called in %s on line %d
TypeError
bat(): Argument #2 ($bar) must be of type string, int given, called in %s on line %d
2 changes: 1 addition & 1 deletion Zend/tests/gh19719.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,4 +18,4 @@ try {

?>
--EXPECTF--
takesInt(): Argument #1 ($x) must be of type int, string given, called in %s on line %d
takesInt(): Argument #1 ($x) must be of type int, non-numeric string given, called in %s on line %d
35 changes: 35 additions & 0 deletions Zend/tests/non_numarix_string_operand_error.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,35 @@
--TEST--
Error message for non-numaric strings in arithmetic contexts
--FILE--
<?php
declare(strict_types=0);

function foo(int $a) { echo $a; }

function msg(TypeError $e){
$split = explode(', called in', $e->getMessage(), 2);
return $split[0];
}

var_dump(1 + "1");
try { var_dump(1 + "hello"); } catch (TypeError $e) { echo $e->getMessage(), "\n"; }
try { var_dump(1 + ""); } catch (TypeError $e) { echo $e->getMessage(), "\n"; }
try { var_dump("hello" + 1); } catch (TypeError $e) { echo $e->getMessage(), "\n"; }
try { var_dump("" + 1); } catch (TypeError $e) { echo $e->getMessage(), "\n"; }

foo("1");
echo "\n";
try { foo("hello"); } catch (TypeError $e) { echo msg($e), "\n"; }
try { foo(""); } catch (TypeError $e) { echo msg($e), "\n"; }
?>
===DONE===
--EXPECT--
int(2)
Unsupported operand types: int + non-numeric string
Unsupported operand types: int + empty string
Unsupported operand types: non-numeric string + int
Unsupported operand types: empty string + int
1
foo(): Argument #1 ($a) must be of type int, non-numeric string given
foo(): Argument #1 ($a) must be of type int, empty string given
===DONE===
28 changes: 14 additions & 14 deletions Zend/tests/numeric_strings/invalid_numeric_string_must_generate_warning_assign.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,81 +164,81 @@ Warning: A non-numeric value encountered in %s on line %d

Warning: A non-numeric value encountered in %s on line %d
int(5)
Unsupported operand types: string + string
Unsupported operand types: non-numeric string + non-numeric string
---

Warning: A non-numeric value encountered in %s on line %d

Warning: A non-numeric value encountered in %s on line %d
int(-2)
Unsupported operand types: string - string
Unsupported operand types: non-numeric string - non-numeric string
---

Warning: A non-numeric value encountered in %s on line %d

Warning: A non-numeric value encountered in %s on line %d
int(143)
Unsupported operand types: string * string
Unsupported operand types: non-numeric string * non-numeric string
---

Warning: A non-numeric value encountered in %s on line %d

Warning: A non-numeric value encountered in %s on line %d
float(0.8947368421052632)
Unsupported operand types: string / string
Unsupported operand types: non-numeric string / non-numeric string
---

Warning: A non-numeric value encountered in %s on line %d

Warning: A non-numeric value encountered in %s on line %d
float(3.0910586430935376E+39)
Unsupported operand types: string ** string
Unsupported operand types: non-numeric string ** non-numeric string
---

Warning: A non-numeric value encountered in %s on line %d

Warning: A non-numeric value encountered in %s on line %d
int(31)
TypeError: Unsupported operand types: string % string
TypeError: Unsupported operand types: non-numeric string % non-numeric string
---

Warning: A non-numeric value encountered in %s on line %d

Warning: A non-numeric value encountered in %s on line %d
int(%d)
Unsupported operand types: string << string
Unsupported operand types: non-numeric string << non-numeric string
string(4) "quis"
---

Warning: A non-numeric value encountered in %s on line %d

Warning: A non-numeric value encountered in %s on line %d
int(0)
Unsupported operand types: string >> string
Unsupported operand types: non-numeric string >> non-numeric string
---

Warning: A non-numeric value encountered in %s on line %d
int(63)

Warning: A non-numeric value encountered in %s on line %d
int(71)
Unsupported operand types: string | int
Unsupported operand types: int | string
Unsupported operand types: non-numeric string | int
Unsupported operand types: int | non-numeric string
---

Warning: A non-numeric value encountered in %s on line %d
int(81)

Warning: A non-numeric value encountered in %s on line %d
int(97)
Unsupported operand types: string & int
Unsupported operand types: int & string
Unsupported operand types: non-numeric string & int
Unsupported operand types: int & non-numeric string
---

Warning: A non-numeric value encountered in %s on line %d
int(28)

Warning: A non-numeric value encountered in %s on line %d
int(252)
Unsupported operand types: string ^ int
Unsupported operand types: int ^ string
Unsupported operand types: non-numeric string ^ int
Unsupported operand types: int ^ non-numeric string
32 changes: 16 additions & 16 deletions Zend/tests/numeric_strings/invalid_numeric_strings_must_generate_warning.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,90 +117,90 @@ Warning: A non-numeric value encountered in %s on line %d

Warning: A non-numeric value encountered in %s on line %d
int(5)
Unsupported operand types: string + string
Unsupported operand types: non-numeric string + non-numeric string
---

Warning: A non-numeric value encountered in %s on line %d

Warning: A non-numeric value encountered in %s on line %d
int(-2)
Unsupported operand types: string - string
Unsupported operand types: non-numeric string - non-numeric string
---

Warning: A non-numeric value encountered in %s on line %d

Warning: A non-numeric value encountered in %s on line %d
int(143)
Unsupported operand types: string * string
Unsupported operand types: non-numeric string * non-numeric string
---

Warning: A non-numeric value encountered in %s on line %d

Warning: A non-numeric value encountered in %s on line %d
float(0.8947368421052632)
Unsupported operand types: string / string
Unsupported operand types: non-numeric string / non-numeric string
---

Warning: A non-numeric value encountered in %s on line %d

Warning: A non-numeric value encountered in %s on line %d
float(3.0910586430935376E+39)
Unsupported operand types: string ** string
Unsupported operand types: non-numeric string ** non-numeric string
---

Warning: A non-numeric value encountered in %s on line %d

Warning: A non-numeric value encountered in %s on line %d
int(31)
TypeError: Unsupported operand types: string % string
TypeError: Unsupported operand types: non-numeric string % non-numeric string
---

Warning: A non-numeric value encountered in %s on line %d

Warning: A non-numeric value encountered in %s on line %d
int(%d)
Unsupported operand types: string << string
Unsupported operand types: non-numeric string << non-numeric string
---

Warning: A non-numeric value encountered in %s on line %d

Warning: A non-numeric value encountered in %s on line %d
int(0)
Unsupported operand types: string >> string
Unsupported operand types: non-numeric string >> non-numeric string
---

Warning: A non-numeric value encountered in %s on line %d
int(63)

Warning: A non-numeric value encountered in %s on line %d
int(71)
Unsupported operand types: string | int
Unsupported operand types: int | string
Unsupported operand types: non-numeric string | int
Unsupported operand types: int | non-numeric string
---

Warning: A non-numeric value encountered in %s on line %d
int(81)

Warning: A non-numeric value encountered in %s on line %d
int(97)
Unsupported operand types: string & int
Unsupported operand types: int & string
Unsupported operand types: non-numeric string & int
Unsupported operand types: int & non-numeric string
---

Warning: A non-numeric value encountered in %s on line %d
int(28)

Warning: A non-numeric value encountered in %s on line %d
int(252)
Unsupported operand types: string ^ int
Unsupported operand types: int ^ string
Unsupported operand types: non-numeric string ^ int
Unsupported operand types: int ^ non-numeric string
---

Warning: A non-numeric value encountered in %s on line %d
int(149)
Unsupported operand types: string * int
Unsupported operand types: non-numeric string * int
---

Warning: A non-numeric value encountered in %s on line %d
int(-151)
Unsupported operand types: string * int
Unsupported operand types: non-numeric string * int
Loading