Fix GH-19520: php_admin_value[extension] in FPM unsafely runs RINIT #20636
+15
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This redifines start_now param to start_mode in php_dl / php_load_extension to allow selection of start hooks to run. And for php-fpm it uses just starting of module.
Girgias
reviewed
Dec 4, 2025
Comment on lines
+22
to
+24
| #define PHP_DL_START_NONE 0 | ||
| #define PHP_DL_START_REQUEST 1 | ||
| #define PHP_DL_START_MODULE 2 |
Member
There was a problem hiding this comment.
Can this not be defined as a C enum?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This redifines start_now param to start_mode in php_dl / php_load_extension to allow selection of start hooks to run. And for php-fpm it uses just starting of module.