Skip to content

Fix 2 docker build problems: volume name too short, dubious ownership #5009

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix 2 docker build problems: volume name too short, dubious ownership #5009

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fa37dfb
Pass full local path to docker
cweiske Nov 21, 2025
c851fd3
Change permissions for cloned repositories
cweiske Nov 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion .docker/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
FROM php:8.2-cli
ARG UID=1000
ARG GID=1000

RUN apt-get update && \
apt-get install -y git default-jre-headless
Expand All @@ -9,7 +11,8 @@ ADD https://api.github.com/repos/php/phd/git/refs/heads/master version-phd.json
ADD https://api.github.com/repos/php/doc-base/git/refs/heads/master version-doc-base.json

RUN git clone --depth 1 https://github.com/php/phd.git && \
git clone --depth 1 https://github.com/php/doc-base.git
git clone --depth 1 https://github.com/php/doc-base.git && \
chown -R $UID:$GID phd doc-base

RUN echo 'memory_limit = 512M' >> /usr/local/etc/php/conf.d/local.ini

Expand Down
6 changes: 4 additions & 2 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ CURRENT_GID := $(shell id -g)
# volumes to our Docker runs.
#

PATHS := -v .:/var/www/en
PATHS := -v ${PWD}:/var/www/en
ifneq ($(wildcard ../doc-base/LICENSE),)
PATHS += -v ${PWD}/../doc-base:/var/www/doc-base
endif
Expand All @@ -28,5 +28,7 @@ php: .docker/built
build: .docker/built

.docker/built:
docker build .docker -t php/doc-en
docker build\
--build-arg UID=${CURRENT_UID} --build-arg GID=${CURRENT_GID}\
.docker -t php/doc-en
touch .docker/built