Add missing PDO_SQLITE constants to documentation #4993
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Note these are deprecated since 8.5 ; basically |
Girgias
requested changes
Nov 27, 2025
Comment on lines
92
to
164
| <section xml:id="ref.pdo-sqlite.constants"> | ||
| &reftitle.constants; | ||
|
|
||
| <constant> | ||
| <name>PDO::SQLITE_ATTR_OPEN_FLAGS</name> | ||
| <description> | ||
| Allows control over how the SQLite database file is opened. | ||
| Accepts a bitmask combination of <constant>PDO::SQLITE_OPEN_READONLY</constant>, | ||
| <constant>PDO::SQLITE_OPEN_READWRITE</constant>, and | ||
| <constant>PDO::SQLITE_OPEN_CREATE</constant>. | ||
| </description> | ||
| <since version="7.3.0"/> | ||
| <seealso> | ||
| <link xlink:href="https://www.sqlite.org/c3ref/open.html">SQLite open flags</link> | ||
| </seealso> | ||
| </constant> | ||
|
|
||
| <constant> | ||
| <name>PDO::SQLITE_OPEN_READONLY</name> | ||
| <description> | ||
| Opens the database in read-only mode. Fails if the database does not exist. | ||
| </description> | ||
| <since version="7.3.0"/> | ||
| </constant> | ||
|
|
||
| <constant> | ||
| <name>PDO::SQLITE_OPEN_READWRITE</name> | ||
| <description> | ||
| Opens the database in read/write mode. Fails if the database does not exist. | ||
| </description> | ||
| <since version="7.3.0"/> | ||
| </constant> | ||
|
|
||
| <constant> | ||
| <name>PDO::SQLITE_OPEN_CREATE</name> | ||
| <description> | ||
| Creates the database if it does not exist. | ||
| </description> | ||
| <since version="7.3.0"/> | ||
| </constant> | ||
|
|
||
| <constant> | ||
| <name>PDO::SQLITE_ATTR_READONLY_STATEMENT</name> | ||
| <description> | ||
| Returns whether a prepared statement is read-only. | ||
| </description> | ||
| <since version="7.4.0"/> | ||
| </constant> | ||
|
|
||
| <constant> | ||
| <name>PDO::SQLITE_ATTR_EXTENDED_RESULT_CODES</name> | ||
| <description> | ||
| Enables or disables the use of extended result codes in SQLite. | ||
| </description> | ||
| <since version="7.4.0"/> | ||
| <seealso> | ||
| <link xlink:href="https://www.sqlite.org/rescode.html">SQLite result and extended result codes</link> | ||
| </seealso> | ||
| </constant> | ||
|
|
||
| <constant> | ||
| <name>PDO::SQLITE_DETERMINISTIC</name> | ||
| <description> | ||
| Indicates that a user-defined function behaves deterministically, which allows | ||
| SQLite to perform additional optimizations. | ||
| </description> | ||
| <since version="7.1.4"/> | ||
| <seealso> | ||
| <link xlink:href="https://www.sqlite.org/c3ref/create_function.html">sqlite3_create_function()</link> | ||
| </seealso> | ||
| </constant> | ||
|
|
||
| </section> |
Member
There was a problem hiding this comment.
Follow what https://www.php.net/manual/en/ref.pdo-pgsql.php does and just point to the Pdo\Sqlite constants, that do need to be documented.
Note for some reason PDO::SQLITE_DETERMINISTIC is documented with the generic PDO constants and should be removed from there.
Contributor
Author
There was a problem hiding this comment.
@Girgias i've removed PDO::SQLITE_DETERMINISTIC, but sorry for the first comment, i don't get it
Co-authored-by: Gina Peter Banyard <girgias@php.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description de la Pull Request
This PR adds missing constants for the PDO_SQLITE driver that are currently available in PHP but not documented.
Issue: #1394
Newly added constants: