This repository was archived by the owner on Jul 16, 2025. It is now read-only.
feat: handle JSON exceptions #15
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nyholm
force-pushed
the
json-exceptions
branch
3 times, most recently
from
005f808 to
0813301
Compare
chr-hertel
reviewed
May 25, 2025
Comment on lines
+31
to
+39
| try { | ||
| $response = $this->jsonRpcHandler->process($message); | ||
| } catch (\JsonException $e) { | ||
| $this->logger->error('Failed to process message', [ | ||
| 'message' => $message, | ||
| 'exception' => $e, | ||
| ]); | ||
| continue; | ||
| } |
Member
There was a problem hiding this comment.
what about unifying this with the other exception handling?
until now the exception handling is isolated within the JsonRpcHandler, but I'd agree that return null is somehow a bit odd
Contributor
Author
There was a problem hiding this comment.
Technically, the other exception handling may throw a json exception.
That is why I need it here... or double try/catch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.