Skip to content
This repository was archived by the owner on Jul 16, 2025. It is now read-only.

fix: make sure we can convert Request and Notification to string #14

Merged
merged 4 commits into from
May 25, 2025
Merged

fix: make sure we can convert Request and Notification to string #14

merged 4 commits into from
May 25, 2025

Conversation

@Nyholm
Copy link
Contributor

@Nyholm Nyholm commented May 25, 2025 •
edited
Loading

This is already used when we are logging.

mcp-sdk/src/Server/JsonRpcHandler.php

Line 56 in 5e795d9

$this->logger->info('Decoded incoming message', ['message' => $message]);

@Nyholm Nyholm changed the title Make sure we can convert Request and Notification to string fix: make sure we can convert Request and Notification to string May 25, 2025
@Nyholm
make sure we can convert Request and Notification to string
3486a5a 
This is already used when we are logging
chr-hertel
chr-hertel approved these changes May 25, 2025
View reviewed changes
Copy link
Member

@chr-hertel chr-hertel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, good one, thanks!

@chr-hertel chr-hertel merged commit 7c1c255 into php-llm:main May 25, 2025
7 checks passed
@Nyholm
Copy link
Contributor Author

Nyholm commented May 25, 2025

Thank you

@chr-hertel chr-hertel added the bug Something isn't working label May 25, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@chr-hertel chr-hertel chr-hertel approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Nyholm @chr-hertel