Skip to content

Fix scope_opener error for abstract/interface methods #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dereuromark merged 1 commit into from
Nov 27, 2025
Merged

Fix scope_opener error for abstract/interface methods #39

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 16 additions & 4 deletions PhpCollective/Sniffs/Commenting/DocBlockSniff.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201,11 +201,23 @@ protected function isFullyTyped(File $phpcsFile, int $stackPtr): bool
}
}

// Check for return type
$hasReturnType = isset($tokens[$stackPtr]['parenthesis_closer']) &&
isset($tokens[$stackPtr]['scope_opener']);
// Check for return type - need parenthesis_closer to find return type
if (!isset($tokens[$stackPtr]['parenthesis_closer'])) {
return false;
}

// For abstract methods or interface methods, there's no scope_opener
// In that case, search until semicolon or end of statement
$searchEnd = $tokens[$stackPtr]['scope_opener'] ?? null;
if ($searchEnd === null) {
// Find the semicolon that ends the method declaration
$searchEnd = $phpcsFile->findNext(T_SEMICOLON, $tokens[$stackPtr]['parenthesis_closer']);
if ($searchEnd === false) {
return false;
}
}

$colonPtr = $phpcsFile->findNext(T_COLON, $tokens[$stackPtr]['parenthesis_closer'], $tokens[$stackPtr]['scope_opener']);
$colonPtr = $phpcsFile->findNext(T_COLON, $tokens[$stackPtr]['parenthesis_closer'], $searchEnd);

if ($colonPtr === false) {
return false; // No return type
Expand Down