Skip to content

chore: Added first unit tests. #97

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dlabaj wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore: Added first unit tests. #97

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion jest.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,5 +14,6 @@ module.exports = {
'\\.(css|less)$': '<rootDir>/styleMock.js'
},
testEnvironment: 'jsdom',
setupFiles: ['./jest.setup.js']
setupFiles: ['./jest.setup.js'],
setupFilesAfterEnv: ['@testing-library/jest-dom']
};
3 changes: 1 addition & 2 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,7 @@
"lint:js": "node --max-old-space-size=4096 node_modules/.bin/eslint packages --ext js,jsx,ts,tsx --cache",
"lint:md": "yarn eslint packages --ext md --no-eslintrc --config .eslintrc-md.json --cache",
"lint": "yarn lint:js && yarn lint:md",
"test": "echo 'Disabled JEST testing'",
"_test": "TZ=EST jest packages",
"test": "TZ=EST jest packages",
"test:a11y": "yarn workspace @patternfly/react-user-feedback test:a11y",
"serve:a11y": "yarn workspace @patternfly/react-user-feedback serve:a11y",
"prepare": "husky install"
Expand Down
1 change: 1 addition & 0 deletions packages/module/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@
"docs:build": "pf-docs-framework build all --output public",
"docs:serve": "pf-docs-framework serve public --port 5001",
"docs:screenshots": "pf-docs-framework screenshots --urlPrefix http://localhost:5001",
"test": "jest",
"test:a11y": "patternfly-a11y --config patternfly-a11y.config",
"serve:a11y": "yarn serve coverage"
},
Expand Down
24 changes: 12 additions & 12 deletions packages/module/patternfly-docs/generated/extensions/user-feedback/design-guidelines.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
import React from 'react';
import { AutoLinkHeader, Example, Link as PatternflyThemeLink } from '@patternfly/documentation-framework/components';
import srcImport0 from '../../../content/design-guidelines/./img/advanced-user-feedback.png';
import srcImport1 from '../../../content/design-guidelines/./img/dropdown-selection.png';
import srcImport2 from '../../../content/design-guidelines/./img/share-feedback.png';
import srcImport3 from '../../../content/design-guidelines/./img/report-bug.png';
import srcImport4 from '../../../content/design-guidelines/./img/research-opportunities.png';
import srcImport5 from '../../../content/design-guidelines/./img/user-feedback-external-links.png';
import srcImport6 from '../../../content/design-guidelines/./img/advanced-user-feedback.png';
import srcImport7 from '../../../content/design-guidelines/./img/dropdown-selection.png';
import srcImport8 from '../../../content/design-guidelines/./img/share-feedback.png';
import srcImport9 from '../../../content/design-guidelines/./img/report-bug.png';
import srcImport10 from '../../../content/design-guidelines/./img/research-opportunities.png';
import srcImport11 from '../../../content/design-guidelines/./img/user-feedback-external-links.png';
Comment on lines +3 to +8
Copy link
Contributor

@thatblindgeye thatblindgeye Nov 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need these updated?

const pageData = {
"id": "User feedback",
"section": "extensions",
Expand Down Expand Up @@ -44,7 +44,7 @@ const Component = () => (
{`Elements`}
</AutoLinkHeader>
<p {...{"className":"pf-v6-c-content--p pf-m-editorial ws-p "}}>
<img src={srcImport0} width={srcImport0.width} height={srcImport0.height} {...{"alt":"Image of advanced feedback modal with annotations","className":"ws-img "}}>
<img src={srcImport6} width={srcImport6.width} height={srcImport6.height} {...{"alt":"Image of advanced feedback modal with annotations","className":"ws-img "}}>
</img>
</p>
<ol {...{"className":"pf-v6-c-content--ol pf-m-editorial ws-ol "}}>
Expand Down Expand Up @@ -86,7 +86,7 @@ const Component = () => (
{`For example, you can allow users to access the modal by selecting a masthead’s help icon and choosing “Share feedback” in the dropdown menu:`}
</p>
<p {...{"className":"pf-v6-c-content--p pf-m-editorial ws-p "}}>
<img src={srcImport1} width={srcImport1.width} height={srcImport1.height} {...{"alt":"Image of expanded dropdown menu with link to sharing feedback","className":"ws-img "}}>
<img src={srcImport7} width={srcImport7.width} height={srcImport7.height} {...{"alt":"Image of expanded dropdown menu with link to sharing feedback","className":"ws-img "}}>
</img>
</p>
<AutoLinkHeader {...{"id":"variations","headingLevel":"h2","className":"ws-title ws-h2"}}>
Expand All @@ -110,7 +110,7 @@ const Component = () => (
{`The general feedback form allows users to enter feedback into a text box and submit.`}
</p>
<p {...{"className":"pf-v6-c-content--p pf-m-editorial ws-p "}}>
<img src={srcImport2} width={srcImport2.width} height={srcImport2.height} {...{"alt":"Image of a form within a modal to share feedback","className":"ws-img "}}>
<img src={srcImport8} width={srcImport8.width} height={srcImport8.height} {...{"alt":"Image of a form within a modal to share feedback","className":"ws-img "}}>
</img>
</p>
</li>
Expand All @@ -122,7 +122,7 @@ const Component = () => (
{`The bug report form allows users to enter feedback into a text box and submit. Its description directs users to a URL where they can submit a support ticket for critical issues.`}
</p>
<p {...{"className":"pf-v6-c-content--p pf-m-editorial ws-p "}}>
<img src={srcImport3} width={srcImport3.width} height={srcImport3.height} {...{"alt":"Image of a form within a modal to report bugs","className":"ws-img "}}>
<img src={srcImport9} width={srcImport9.width} height={srcImport9.height} {...{"alt":"Image of a form within a modal to report bugs","className":"ws-img "}}>
</img>
</p>
</li>
Expand All @@ -134,7 +134,7 @@ const Component = () => (
{`The user research opt-in form allows users to enter their email address to participate in future research efforts.`}
</p>
<p {...{"className":"pf-v6-c-content--p pf-m-editorial ws-p "}}>
<img src={srcImport4} width={srcImport4.width} height={srcImport4.height} {...{"alt":"Image of a form within a modal to sign up for research opportunities","className":"ws-img "}}>
<img src={srcImport10} width={srcImport10.width} height={srcImport10.height} {...{"alt":"Image of a form within a modal to sign up for research opportunities","className":"ws-img "}}>
</img>
</p>
</li>
Expand All @@ -146,7 +146,7 @@ const Component = () => (
{`Selecting an item redirects users to an external URL (like a qualtrics form) that opens in a separate tab.`}
</p>
<p {...{"className":"pf-v6-c-content--p pf-m-editorial ws-p "}}>
<img src={srcImport5} width={srcImport5.width} height={srcImport5.height} {...{"alt":"Image of modal with links to external forms","className":"ws-img "}}>
<img src={srcImport11} width={srcImport11.width} height={srcImport11.height} {...{"alt":"Image of modal with links to external forms","className":"ws-img "}}>
</img>
</p>
</React.Fragment>
Expand Down
4 changes: 2 additions & 2 deletions packages/module/src/Feedback/FeedbackForm.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ export const FeedbackForm = ({
async function handleModalSubmission() {
try {
const emailAddress = checked && currentEmail ? currentEmail : '';
onSubmit(emailAddress, textAreaValue, checked);
await onSubmit(emailAddress, textAreaValue, checked);
} catch (err) {
handleFeedbackError();
}
Expand Down Expand Up @@ -93,7 +93,7 @@ export const FeedbackForm = ({
{textAreaHidden ? (
''
) : (
<FormGroup label={textareaLabel} fieldId="horizontal-form-exp">
<FormGroup label={textareaLabel} fieldId="feedback-description-text">
<TextArea
value={textAreaValue}
onChange={(_event, value) => setTextAreaValue(value)}
Expand Down
Loading