Skip to content

Conversation

@thatblindgeye
Copy link
Contributor

Closes #768

@patternfly-build
Copy link

patternfly-build commented Nov 25, 2025

@thatblindgeye thatblindgeye marked this pull request as ready for review November 25, 2025 19:35
Copy link
Member

@rebeccaalpert rebeccaalpert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We may also want to check to see how the additional items work in a resizable toolbar/different breakpoints, etc. if we are not completely offloading toolbar creation to the end user.


### Drawer with search actions

The conversation history drawer supports additional customization through `searchActionStart` and `searchActionEnd` props, which allow you to add controls before and after the search input field. These props are useful for adding filtering, sorting, or other search-related functionality.
Copy link
Contributor

@edonehoo edonehoo Nov 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The conversation history drawer supports additional customization through `searchActionStart` and `searchActionEnd` props, which allow you to add controls before and after the search input field. These props are useful for adding filtering, sorting, or other search-related functionality.
You can customize the search experience within the conversation history drawer via the `searchActionStart` and `searchActionEnd` props, which provide additional search controls before and after the input field. These props are useful for adding filtering, sorting, or other search-related functionality.

a small tweak - otherwise I like what you have!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is done

Copy link
Contributor

@edonehoo edonehoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fabulous to me 👍

Copy link
Member

@rebeccaalpert rebeccaalpert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's fine by me - you probably just want to make sure the yarn.lock file gets dropped. Up to you and Nicole if you want to allow the semi-custom toolbar approach as well as the custom one!

Copy link
Contributor

@nicolethoen nicolethoen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Curious why the package-lock.json and yarn.lock files are updated here?
Do you want to double check those updates are both necessary?

@thatblindgeye thatblindgeye force-pushed the iss768 branch 2 times, most recently from 85ef6a2 to bde4d90 Compare December 4, 2025 18:05
@kaylachumley
Copy link

copy/text question: so it says "show search action at start" and "show search action at end", wondering if it should say "show filter action start" and "show filter action end" instead since the action is a filter and the tooltip also says filter?

also for the search icon/action at start, is anything supposed to happen when clicking the icon? nothing happens for me in firefox. wasnt sure if that was intentional because the product can configure their own filter types?

the filter icon button padding also feels a lot larger than the sort icon - can we bump down the padding on the right and left from 16px to be 8px?
Screenshot 2025-12-04 at 1 14 29 PM

@thatblindgeye
Copy link
Contributor Author

copy/text question: so it says "show search action at start" and "show search action at end", wondering if it should say "show filter action start" and "show filter action end" instead since the action is a filter and the tooltip also says filter?

So the way it's currently built out, a consumer can really add in whatever action they want at start/end. The example was sort of just a couple of potential actions that might be used (or int he case of the sort action, one that was mentioned in the original issue). That's really the only reason I kept the verbiage a bit vague for the example, since it could be anything.

also for the search icon/action at start, is anything supposed to happen when clicking the icon? nothing happens for me in firefox. wasnt sure if that was intentional because the product can configure their own filter types?

Not really - it logs something in the console is all. Mainly just wanted to show the sort action a bit more in depth with a Select menu upon clicking it.

the filter icon button padding also feels a lot larger than the sort icon - can we bump down the padding on the right and left from 16px to be 8px?

We could, though it would be more custom styling in the example since any Button variant could be rendered there by the consumer (or potentially anything could be rendered there, really).

@nicolethoen nicolethoen merged commit 6abd00d into patternfly:main Dec 10, 2025
7 checks passed
@github-actions
Copy link

🎉 This PR is included in version 6.5.0-prerelease.26 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Feature Request: Allow adding a Sort Button Next to the Search input field in ChatbotConversationHistoryNav

6 participants