Skip to content

Conversation

@krebil
Copy link

@krebil krebil commented Aug 11, 2022

Fixes 39

The initial draft for uSync implementation.

  • Sync meta field- / SEO field values

  • Add reporting to meta fields

  • Support language variants

  • Sync SEO settings

  • Add reporting to Seo settings

@patrickdemooij9 take a look and let me know if you want any changes, I'll look into synching the settings portion either later today or tomorrow morning.

Other Notes:

  • I've used the default content serializer as the basis
  • Maybe there should also be some logic in place to detect whether the open graph image exists on import

@krebil krebil marked this pull request as draft August 11, 2022 10:16
@patrickdemooij9
Copy link
Owner

@krebil absolutely amazing! Export and import work great!

There is one issue that I can see with the report function:
image

I've tried to fix it, but I can't quite figure out where it is going wrong. I think the error is thrown here (https://github.com/KevinJump/uSync/blob/ab2f1f0e26683da6c8c600fd8de5dc9acf94af44/uSync.Core/Serialization/SyncSerializerRoot.cs#L246), but we override that code (I also tried overriding the one with 3 parameters), but it doesn't get hit when reporting... Almost like that serializer isn't being called on report.

Also noticed an error on startup, so I quickly fixed that.

But amazing work so far!

@krebil
Copy link
Author

krebil commented Aug 11, 2022

Ah yes I haven't done anything with reporting yet. It probably needs an override in the handler file. I'll look into it in the morning :)

I also haven't tested language variants yet

@krebil
Copy link
Author

krebil commented Aug 12, 2022

@patrickdemooij9
I've added language variants and reporting both seem to work alright.
Next up is the whole settings section

@patrickdemooij9
Copy link
Owner

Hi @krebil
Have you already started on the settings section? Otherwise I might be able to help out with that this weekend

@krebil
Copy link
Author

krebil commented Sep 2, 2022

@patrickdemooij9 Sounds great, I have been really busy with work. So I've only looked at it briefly. Usync is structured towards saving Tree items. So I don't know what the right structure would be. For the values section I've piggy backed unto the content items themselves. And something similar could be done with the document types.

Let me know if you need anything. I'll be working this weekend. But I'll be available

@krebil
Copy link
Author

krebil commented Nov 22, 2022

I've been looking on and off for a while. I can't find much reference to pulling data outside of a tree with USync and everything I've come up with so far feels hacky.

Umbraco deploy seems easier though. So maybe I'll give that a shot and see if that implementation gives some more insight into this

@ianleeder
Copy link
Contributor

Any progress on this?

I'd also be interested to know if it would work for uSync (Complete) Publisher - direct sync server-server.

@krebil
Copy link
Author

krebil commented Mar 13, 2023

I got pointed in another direction by Kevin, KevinJump/uSync#479
I'll try this out sometime this week

@krebil
Copy link
Author

krebil commented Mar 16, 2023

I'm about halfway done with this, and should be done at the end of the week. This approach seems much cleaner. I'll move to a new pull request targeting v11

@patrickdemooij9 would you be up for reviewing?

@patrickdemooij9
Copy link
Owner

Yeah, I'll take a look at what you have tonight and then give it another look when it's done!

@krebil
Copy link
Author

krebil commented Mar 16, 2023

I've moved to another pull request #175
@patrickdemooij9

@krebil krebil closed this Mar 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Connect with uSync

3 participants