Skip to content

fix: Select input name instead of file in ParseFile #1012

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 16, 2024
Merged

fix: Select input name instead of file in ParseFile #1012

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d20c719
fix: parse file name
mbfakourii Oct 12, 2024
944b77d
test: add test for ParseFile and ParseXFile
mbfakourii Oct 12, 2024
a3e44b6
remove comments
mtrezza Oct 12, 2024
d78c59d
chore: bump version and add changes in CHANGELOG.md
mbfakourii Oct 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/dart/lib/src/objects/parse_file.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
super.client,
super.autoSendSessionId})
: super(
name: file != null ? path.basename(file.path) : name!,
name: name ?? path.basename(file?.path ?? ''),

Check warning on line 14 in packages/dart/lib/src/objects/parse_file.dart

View check run for this annotation

Codecov / codecov/patch

packages/dart/lib/src/objects/parse_file.dart#L14 

Added line #L14 was not covered by tests
);

File? file;
Expand Down
2 changes: 1 addition & 1 deletion packages/dart/lib/src/objects/parse_x_file.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
super.client,
super.autoSendSessionId})
: super(
name: file != null ? path.basename(file.path) : name!,
name: name ?? path.basename(file?.path ?? ''),

Check warning on line 14 in packages/dart/lib/src/objects/parse_x_file.dart

View check run for this annotation

Codecov / codecov/patch

packages/dart/lib/src/objects/parse_x_file.dart#L14 

Added line #L14 was not covered by tests
);

XFile? file;
Expand Down
Loading