DOC: 62437 Replace @Substitution and @Appender in core/groupby/groupby.py #63234
+62
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josquinlarsen
changed the title
josquinlarsen
changed the title
6 tasks
josquinlarsen
changed the title
rhshadrach
requested changes
Dec 4, 2025
Comment on lines
799
to
803
| >>> df | ||
| A B | ||
| A B | ||
| 0 a 1 | ||
| 1 b 2 | ||
| 2 a 3 |
Member
There was a problem hiding this comment.
This change is wrong, the columns should be adjusted. Is pre-commit doing this with the ruff formater?
Author
There was a problem hiding this comment.
Fixed! I think this is a holdover from the contents of the generated docstring I printed to console.
pandas/core/groupby/groupby.py
Outdated
| >>> df.groupby('A').pipe(lambda x: x.max() - x.min()) | ||
| B | ||
| >>> df.groupby("A").pipe(lambda x: x.max() - x.min()) | ||
| B |
Author
There was a problem hiding this comment.
I misunderstood the example. Fixed alignment of A B to match columns
Thank you for the feedback!
Author
There was a problem hiding this comment.
I tried to combine lines 810/811 (i.e. A B) but that was causing Code Checks/Docstrings to fail. I reverted to the two lines and it's passing now, but doesn't look right in the file. I've not been able to find other examples that follow a pattern like that to see what others have done
josquinlarsen
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had issues updating my original PR (#63201), I redid it to account for formatting fixes. File: pandas/core/groupby/groupby.py
@Appender,@Substitution,@docwith inlined docstrings #62437 (Replace xxxx with the GitHub issue number)doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.AGENTS.md.