Skip to content

Adding container name to error message along with internal port, help… #249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Adding container name to error message along with internal port, help… #249

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
62cd4f3
Adding container name to error message along with internal port, help…
Sep 4, 2018
8f0761e
Adding config file for circle ci
Sep 4, 2018
27e485c
Delete config.yml
saavkaar Oct 18, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docker-compose-rule-core/src/main/java/com/palantir/docker/compose/connection/Container.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ public SuccessOrFailure portIsListeningOnHttp(int internalPort, Function<DockerP
return SuccessOrFailure.failure("Internal port " + internalPort + " is not listening in container " + containerName);
}
return port.isHttpRespondingSuccessfully(urlFunction, andCheckStatus)
.mapFailure(failureMessage -> internalPort + " does not have a http response from " + urlFunction.apply(port) + ":\n" + failureMessage);
.mapFailure(failureMessage -> containerName+":"+internalPort + " does not have a http response from " + urlFunction.apply(port) + ":\n" + failureMessage);
} catch (Exception e) {
return SuccessOrFailure.fromException(e);
}
Expand Down