Skip to content

Conversation

@Eric-Alvarez
Copy link
Contributor

Before this PR

DefaultCas is package-private which does not allow building custom truststores that trust default cas

After this PR

==COMMIT_MSG==
==COMMIT_MSG==
DefaultCas class is public to allow clients to build custom truststores

Possible downsides?

@changelog-app
Copy link

changelog-app bot commented Nov 25, 2025

Generate changelog in changelog/@unreleased

Type (Select exactly one)

  • Feature (Adding new functionality)
  • Improvement (Improving existing functionality)
  • Fix (Fixing an issue with existing functionality)
  • Break (Creating a new major version by breaking public APIs)
  • Deprecation (Removing functionality in a non-breaking way)
  • Migration (Automatically moving data/functionality to a new system)

Description

Make DefaultCas public to allow building custom truststores

Check the box to generate changelog(s)

  • Generate changelog entry

@changelog-app
Copy link

changelog-app bot commented Nov 25, 2025

Successfully generated changelog entry!

Need to regenerate?

Simply interact with the changelog bot comment again to regenerate these entries.


📋Changelog Preview

💡 Improvements

  • Make DefaultCas public to allow building custom truststores (#3312)

@pkoenig10
Copy link
Member

I don't think it should be this libraries responsibility to provide this utility for arbitrary clients. Different clients may have very different expectations or requirements for what is included here. Exposing this API greatly increases the responsibility shouldered by this library for things that are mostly not it's concern.

If we wanted to expose a library for this, it should be pulled out to a dedicated library where that is expressly it's goal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants