chore: fix argument to main test function #1338
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When trying to run tests with `hatch run test path/to/test.py::test_fo`, hatch keeps the first `tests/` argument, which ends up including all of the tests anyway. Signed-off-by: JP-Ellis <josh@jpellis.me>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the test command configuration to properly handle user-specified test paths. The change allows users to run specific tests with hatch run test path/to/test.py::test_name without inadvertently running all tests due to the hardcoded tests/ argument being retained.
Key Changes:
- Modified the pytest command to use
{args:tests/}instead of hardcodedtests/ {args}, makingtests/a default value that gets replaced when arguments are provided
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
❌ 8 Tests Failed:
View the top 3 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
When trying to run tests with
hatch run test path/to/test.py::test_fo, hatch keeps the firsttests/argument, which ends up including all of the tests anyway.🚨 Breaking Changes🔥 Motivation
🔨 Test Plan
🔗 Related issues/PRs