Skip to content

Conversation

@TG1999
Copy link
Collaborator

@TG1999 TG1999 commented Aug 6, 2025

@pombredanne
Copy link
Member

@TG1999 I am not sure this would be the way to go. I think we should instead use a git module to get the new spec tests, but we do not want to continue to extend this JSON file.

@TG1999
Copy link
Collaborator Author

TG1999 commented Aug 6, 2025

@pombredanne got it, so we need to use https://github.com/package-url/purl-spec/tree/main/tests as a git module for tests.

Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
@TG1999 TG1999 force-pushed the add_tests_for_purl-spec branch from 5f658a8 to 4c237ce Compare August 7, 2025 06:44
TG1999 added 6 commits August 7, 2025 12:16
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
@TG1999 TG1999 marked this pull request as draft August 7, 2025 07:54
TG1999 added 3 commits August 7, 2025 18:36
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
@TG1999 TG1999 marked this pull request as ready for review August 7, 2025 13:42
TG1999 added 2 commits August 7, 2025 20:19
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
netbsd-srcmastr pushed a commit to NetBSD/pkgsrc that referenced this pull request Aug 8, 2025
0.17.5 (2025-08-06)

- Remove support for getting download URL for qpkg in ``purl2url``.
  package-url/packageurl-python#202

0.17.4 (2025-08-05)

- Add support for getting download URL for debian, apk, qpkg in ``purl2url``.
  package-url/packageurl-python#201
TG1999 added 6 commits August 12, 2025 14:44
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
@pombredanne pombredanne requested a review from tdruez August 14, 2025 11:51
@tdruez tdruez requested review from pombredanne and removed request for tdruez August 14, 2025 15:03
Copy link
Collaborator

@keshav-space keshav-space left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @TG1999, few nits for your consideration.

Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
Copy link
Collaborator

@keshav-space keshav-space left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @TG1999, LGTM!

@keshav-space keshav-space merged commit 62d1f73 into main Aug 19, 2025
38 checks passed
@keshav-space keshav-space deleted the add_tests_for_purl-spec branch August 19, 2025 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants