Skip to content

Don't escape colons in qualifier values #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
melotic wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Don't escape colons in qualifier values #24

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/PackageUrl.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,7 +160,7 @@ public override string ToString()
purl.Append("?");
foreach (var pair in Qualifiers)
{
string encodedValue = WebUtility.UrlEncode(pair.Value).Replace(EncodedSlash, "/");
string encodedValue = WebUtility.UrlEncode(pair.Value).Replace(EncodedSlash, "/").Replace(EncodedColon, ":");
purl.Append(pair.Key.ToLower());
purl.Append('=');
purl.Append(encodedValue);
Expand Down
14 changes: 14 additions & 0 deletions tests/TestAssets/test-suite-data.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -302,6 +302,20 @@
"subpath": null,
"is_invalid": false
},
{
"description": "colons and slashes aren't escaped in qualifer values",
"purl": "pkg:cocoapods/MapsIndoors@3.24.0?repository_url=https://contoso.com",
"canonical_purl": "pkg:cocoapods/MapsIndoors@3.24.0?repository_url=https://contoso.com",
"type": "cocoapods",
"namespace": null,
"name": "MapsIndoors",
"version": "3.24.0",
"qualifiers": {
"repository_url": "https://contoso.com"
},
"subpath": null,
"is_invalid": false
},
{
"description": "cocoapods names are case sensitive",
"purl": "pkg:cocoapods/MapsIndoors@3.24.0",
Expand Down