Parse AsPath from string; get originating / transiting #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Partial support means that the files containing records with this attribute will not abort the file parsing, however this attribute will not be added to the record's list of attributes since it would require additional and painful refactorings - attributes are saved in a Vector that uses the type as index. The version was updated to 0.0.2-SNAPSHOT.
[feature/SCRUM-3461] ignore large_community
…a-mrt into ripencc-keep-binary
Adding bgpId attribute to Open object. Deprecating getPeerIP from StateChange object and adding getPeer as access to gatewayIp attribute
New methods in order to make the java-mrt library compatible with old BGP type records.
…tion, they are going to be always Ipv4, so setting AFI to 1 in these cases. Ipv6 will be defined in Attributes.
…. It has been added a flag isInIpv4EmbeddedIpv6Format
New fixes from RIPE NCC side :)
…e java-mrt library to print correctly the ipv4 embedded in ipv6. It has been needed to add the isIpv4EmbeddedIpv6 flag in all ip address related classes. Also in the classes that returned ip addresses as java.net library it has been added method to return byte[].
RFC5065 Section 3:
3 AS_CONFED_SEQUENCE
4 AS_CONFED_SET
Even more fixes for unsigned binary operations, IPv4 mapped/embedded in IPv6, and naughty bug in MrtConstants
- Fix byte array re-use between consequently parsed objects - Add support for all remaining subtypes of (deprecated) BGP type - Add lenient parse mode (to parse dump files generated by broken versions of Zebra/Quagga) - Minor bug fixes
This is a terrible bug :(
This is an update message without any withdrawals or announcements
- Parse from String - get originating / transiting AS
andrekampert
changed the title
- Do not rely on Exceptions for normal control flow - Use StringBuilder instead of StringBuffer when possible - Utility method on ASPath to build string of List of path elements
Also do not overwrite other attributes with UnsupportedAttribute :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We would like to parse the AsPath toString representation back to AsPath for serialisation purposes. Also, we often need to determine which elements in the path are transiting / originating. We felt this functionality was best added here.