Do not use "record" in exceptions, as it could be huge in malformed MRT. #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Partial support means that the files containing records with this attribute will not abort the file parsing, however this attribute will not be added to the record's list of attributes since it would require additional and painful refactorings - attributes are saved in a Vector that uses the type as index. The version was updated to 0.0.2-SNAPSHOT.
[feature/SCRUM-3461] ignore large_community
…a-mrt into ripencc-keep-binary
Adding bgpId attribute to Open object. Deprecating getPeerIP from StateChange object and adding getPeer as access to gatewayIp attribute
New methods in order to make the java-mrt library compatible with old BGP type records.
…tion, they are going to be always Ipv4, so setting AFI to 1 in these cases. Ipv6 will be defined in Attributes.
- Do not rely on Exceptions for normal control flow - Use StringBuilder instead of StringBuffer when possible - Utility method on ASPath to build string of List of path elements
Also do not overwrite other attributes with UnsupportedAttribute :)
We aren't going to publish it to RIPE's nexus from here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While trying to parse malformed MRT with
BGPFileReader, it "hangs" in creating theBGPFileReaderException, because therecordlen(and, respectively,record) could be surprisingly big in a malformed MRT record.