Make compiler build with Dune package management faster #25
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This lets Dune package management use build concurrency, which is currently not the case. Currently, when we build the OxCaml compiler with Dune package management, it fails to pick up concurrency and builds on a single thread because of multiple levels of Dune being present. (Dune package on the outside, and the OxCaml compiler itself using Dune to build the compiler). This issue is described here: ocaml/dune#12737.
This could be fixed in Dune by decoupling the environment variable
INSIDE_DUNEand build concurrency. We have an open PR for the same: ocaml/dune#12800. However, this alone doesn't fix the issue as the older version of Dune used by the OxCaml compiler doesn't have this fix. A solution until this gets merged into Dune and the version of Dune is updated in OxCaml is to manually unset the environment variable before building. This patch proposes to do that. This brings the build time on par with the opam build. This is building thehello-oxcamlproject.Before patch (Dune package management):
After patch (Dune package management):
Opam build: