feat(localisation): add Simpled Chinese (zh-Hans) language support #94
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
Hi @othyn , thanks for creating this awesome tool! It's been really helpful for me. I've added Simplified Chinese (zh-Hans) support to make it accessible to more users. Could you please review this PR? Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added support for Simplified Chinese (zh-Hans) to the app.
The changes include adding
zh-Hans.lproj/and its contents, and updating project.pbxproj to include the new localization.Related Issue
Refs: #10
Motivation and Context
Help is wanted to add localisation for more languages and there isn't for Simplified Chinese already so I added it.
How Has This Been Tested?
I used Xcode application language setting in scheme run options.
Launched the app to confirm Chinese strings appear in place of English.
Manually reviewed all translated strings in zh-Hans.lproj/Localizable.strings.
Types of changes
[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)