S3 asset upload for deploy command #39
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
detjensrobert
force-pushed
the
dr/deploy-upload
branch
3 times, most recently
from
5a7f594 to
87915dc
Compare
KekoaM
approved these changes
Mar 30, 2025
Contributor
KekoaM
left a comment
KekoaM
left a comment
There was a problem hiding this comment.
Overall looks good, may want to provide slightly more info if docker socket connection fails.
| .await | ||
| // truncate error chain with new error (returned error is way too verbose) | ||
| .map_err(|_| { | ||
| anyhow!("could not talk to Docker daemon (is DOCKER_HOST correct?)") |
Contributor
There was a problem hiding this comment.
Do we want to print any debug info here?
not critical, but something to think about
Contributor
Author
There was a problem hiding this comment.
The error returned by bollard is not particularly helpful so I don't think there's not much other debug info we could print:
[ERROR] could not access container registry
Caused by:
0: Error in the hyper legacy client: client error (Connect)
1: client error (Connect)
2: No such file or directory (os error 2)
Signed-off-by: Robert Detjens <github@detjens.dev>
This makes things cleaner than a big `async move` block Signed-off-by: Robert Detjens <github@detjens.dev>
Signed-off-by: Robert Detjens <github@detjens.dev>
Signed-off-by: Robert Detjens <github@detjens.dev>
detjensrobert
force-pushed
the
dr/deploy-upload
branch
from
87915dc to
3eceb00
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements the asset file upload portion of the
deploycommand.Asset files are uploaded to
<the bucket>/assets/${CHAL/SLUG}/${FILENAME}(e.g./assets/misc/foo/things.zip)Depends on #38 and includes its commits.