Build command implementation #19
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Robert Detjens <github@detjens.dev>
Signed-off-by: Robert Detjens <github@detjens.dev>
- coerce string `build:` directory into full build context object - allow only one of either `build:` or `image:` fields Signed-off-by: Robert Detjens <github@detjens.dev>
also adds a directory field to ChallengeConfig struct to hold the reference path for the challenge Signed-off-by: Robert Detjens <github@detjens.dev>
bollard wants to use HashMap to talk to the docker daemon, and we don't need the extra features BTreeMap offers. simpler to agree on HashMap. Signed-off-by: Robert Detjens <github@detjens.dev>
does not push yet, and probably missing other stuff Signed-off-by: Robert Detjens <github@detjens.dev>
Signed-off-by: Robert Detjens <github@detjens.dev>
Makes more sense for these to be comments. Signed-off-by: Robert Detjens <github@detjens.dev>
Signed-off-by: Robert Detjens <github@detjens.dev>
Signed-off-by: Robert Detjens <github@detjens.dev>
detjensrobert
force-pushed
the
dr/build-implementation
branch
from
9f244b8 to
147a138
Compare
cacama-valvata
approved these changes
Nov 6, 2024
cacama-valvata
left a comment
cacama-valvata
left a comment
There was a problem hiding this comment.
Reviewed synchronously 11/05/24 -- approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements
beavercds build. Uses the/buildenpoint on the daemon REST API for compatibility with Docker and Podman.This uses the "legacy" docker build api, not Buildkit /docker buildx. Dealing with Buildkit is possible, but more complicated and not cross-compatible with Podman, and spinning up an isolated Buildkit builder container is even more complicated to talk to. This still works with Docker as they have not removed support for the legacy endpoint yet; I am not sure if the API endpoint is actually Buildkit under the hood or not.EDIT: the REST api endpoint is actually Buildkit now.
Depends on
#18, #20