initial code sync #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…added sample csv for vendors, updated readme, added licenses
…structions, added trust rest to gitignore, renamed mkdocs to deployment docs to avoid confusion
oracle-contributor-agreement
bot
added
the
OCA Verified
Contributor
|
Skimming through again this looks fine for publishing. The only comment I would make it maybe add a note down the line for the datasets e.g. vendors table to explicitly mention they are demo/example names and any overlap with real company names is purely coincidental. Other than that it should be good. Do we want to squash these commits? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.