Qr code component challenge #155
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit df8b871.
almirsarajcic
requested changes
Jan 29, 2024
Member
almirsarajcic
left a comment
almirsarajcic
left a comment
There was a problem hiding this comment.
Pull from upstream. I recommend reading more about git and GitHub.
Author
|
Noted
ᐧ
…On Mon, Jan 29, 2024 at 11:56 AM Almir Sarajčić ***@***.***> wrote:
***@***.**** requested changes on this pull request.
Pull from upstream. I recommend reading more about git and GitHub.
—
Reply to this email directly, view it on GitHub
<#155 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AXL2DLZIMMHKDG2L5ODJDRLYQ5P2JAVCNFSM6AAAAABCL4VS62VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTQNBYGEZDQOBRGQ>
.
You are receiving this because you authored the thread.Message ID:
***@***.***
com>
|
Avoid potential issues with multiple links on the page.
Fix Tailwind CSS config. Improve test to save screenshot for two viewport sizes.
almirsarajcic
requested changes
Jan 31, 2024
Member
There was a problem hiding this comment.
Now the tests are failing.
frontend_mentor_challenges/package.json
Lines 19 to 28 in 7282120
Run the
npm run test command locally and fix it until everything is passing.
akinyiv
force-pushed
the
qr-code-component-challenge
branch
from
ae74efd to
50b31a2
Compare
akinyiv
force-pushed
the
qr-code-component-challenge
branch
from
50b31a2 to
2f5528c
Compare
almirsarajcic
approved these changes
Feb 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.