fix(svg): compatible with the original icon behavior. #3891
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… or secondary color is passed, remove the fill attribute inside the icon
WalkthroughTwo targeted adjustments to styling and build automation: input disabled state styling switches from a disabled text color to secondary text color with inline documentation, and SVG color token substitutions simplify by removing hex code fallback values. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes
Poem
Pre-merge checks and finishing touches❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
packages/vue-common/src/index.ts (1)
411-411: Consider targeting specific SVG elements instead of all descendants.Using
querySelectorAll('*')selects all descendant elements. For better performance and accuracy, target only SVG shape elements that typically have fill attributes.- this.$el?.querySelectorAll('*').forEach((path) => path.removeAttribute('fill')) + this.$el?.querySelectorAll('path, circle, rect, polygon, ellipse, line, polyline').forEach((el) => el.removeAttribute('fill'))
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
packages/vue-common/src/index.ts(1 hunks)
🧰 Additional context used
🧠 Learnings (1)
📚 Learning: 2024-11-25T03:24:05.740Z
Learnt from: Davont
Repo: opentiny/tiny-vue PR: 2513
File: packages/vue/src/huicharts/huicharts-sunburst/src/chart-sunburst.vue:30-32
Timestamp: 2024-11-25T03:24:05.740Z
Learning: 在位于`packages/vue/src/huicharts/huicharts-sunburst/src/chart-sunburst.vue`的组件中，当使用`chart-core`时，应删除错误的`option`定义，使用`chart-core`中的`huiChartOption`。
Applied to files:
packages/vue-common/src/index.ts
packages/vue-common/src/index.ts
Outdated
Comment on lines
407
to
413
| mounted() { | ||
| // 如果属性没有主副色，则遍历svg的所有内部元素，移除 fill 属性。 | ||
| // 注意：移除后不能还原，所以： 如果用户使用时不传入主副色，后来修改主副色有值，也无法再把fill还原回来的。 | ||
| if (this.firstColor === '' && this.secondColor === '') { | ||
| this.$el?.querySelectorAll('*').forEach((path) => path.removeAttribute('fill')) | ||
| } | ||
| } |
There was a problem hiding this comment.
Non-reactive behavior may break user expectations.
The mounted hook runs only once. If firstColor or secondColor props change from empty to non-empty values after mount, the fill attributes won't be restored. This breaks Vue's reactivity model and could confuse users who expect props to work reactively.
Consider using a watcher or computed property to handle this reactively:
- },
- mounted() {
- // 如果属性没有主副色，则遍历svg的所有内部元素,移除 fill 属性。
- // 注意：移除后不能还原,所以： 如果用户使用时不传入主副色,后来修改主副色有值,也无法再把fill还原回来的。
- if (this.firstColor === '' && this.secondColor === '') {
- this.$el?.querySelectorAll('*').forEach((path) => path.removeAttribute('fill'))
- }
+ },
+ watch: {
+ firstColor: {
+ handler(newVal, oldVal) {
+ if (newVal === '' && this.secondColor === '') {
+ this.$el?.querySelectorAll('path, circle, rect, polygon, ellipse, line, polyline').forEach((el) => el.removeAttribute('fill'))
+ }
+ },
+ immediate: false
+ },
+ secondColor: {
+ handler(newVal, oldVal) {
+ if (newVal === '' && this.firstColor === '') {
+ this.$el?.querySelectorAll('path, circle, rect, polygon, ellipse, line, polyline').forEach((el) => el.removeAttribute('fill'))
+ }
+ },
+ immediate: false
+ }
+ },
+ mounted() {
+ // Remove fill attributes on initial mount if no colors specified
+ if (this.firstColor === '' && this.secondColor === '') {
+ this.$el?.querySelectorAll('path, circle, rect, polygon, ellipse, line, polyline').forEach((el) => el.removeAttribute('fill'))
+ }
}Alternatively, if the one-way behavior is intentional to match legacy icon behavior, document this clearly in the component's public API.
Committable suggestion skipped: line range outside the PR's diff.
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
internals/automate/src/copy-svgs-raw/index.ts (1)
81-88: Behavior change: CSS vars now have no hex fallback; confirm tokens are always definedSwitching from
var(--tiny-*-color, #xxxxxx)tovar(--tiny-*-color)means that when these tokens are not defined, SVGfillwill no longer fall back to the design hex, but instead to the default/inherited fill behavior. That seems consistent with the PR goal of matching the original icon behavior, but it does change the built SVG output in any context where the vars are missing.Can you confirm that
--tiny-first-colorand--tiny-second-colorare guaranteed to be defined wherever these icons are used, or that the new fallback behavior is explicitly desired? If not, you might want to keep the hex fallback or add a theme-level fallback instead.Minor nit: the two second‑color replacements differ only by case (
#AEAEAE/#aeaeae). If you ever touch this again, you could normalize content case or use a case‑insensitive pattern to avoid duplication, but it’s not blocking.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (298)
packages/theme-saas/src/svgs/acceptance-filled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/acceptance.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/activation-filled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/activation.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/administrator-filled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/administrator.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/agenda-view-filled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/agenda-view.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/area-chart-filled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/area-chart.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/arrow-down-filled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/arrow-down.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/arrow-left-filled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/arrow-left.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/arrow-right-filled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/arrow-right.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/arrow-up-filled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/arrow-up.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/ascending-filled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/ascending.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/association-filled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/association.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/attachment-filled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/attachment.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/audio-filled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/audio.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/audit-filled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/audit.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/automatic-assessment-filled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/automatic-assessment.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/bar-chart-filled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/bar-chart.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/batch-fill-filled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/batch-fill.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/befilter-filled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/befilter.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/boat-filled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/boat.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/calculator-filled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/calculator.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/calendar-filled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/calendar.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/card-modeline-filled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/card-modeline.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/check-filled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/check-out-filled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/check-out.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/check.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/checked-linear-filled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/checked-linear.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/chevron-down-filled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/chevron-down.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/chevron-left-filled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/chevron-left.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/chevron-right-filled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/chevron-right.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/chevron-up-filled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/chevron-up.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/clear-filter-filled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/clear-filter.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/clock-work-filled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/clock-work.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/close-circle-filled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/close-circle.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/close-filled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/close-square-filled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/close-square.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/close.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/cloud-download-filled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/cloud-download.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/coin-filled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/coin.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/commission-filled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/commission.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/company-filled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/company.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/conment-refresh-filled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/conment-refresh.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/connect-square-filled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/connect-square.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/copy-filled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/copy.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/course-filled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/course.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/crop-filled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/crop.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/cue-l-filled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/cue-l.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/currency-filled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/currency.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/custom-filled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/custom.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/customer-service-filled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/customer-service.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/customs-clearance-form-filled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/customs-clearance-form.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/customs-declaration-filled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/customs-declaration.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/daily-visits-filled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/daily-visits.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/default-filled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/default.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/defined-filtration-filled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/defined-filtration.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/delegated-processing-filled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/delegated-processing.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/delete-page-filled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/delete-page.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/deleted-filled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/deleted.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/delta-down-o-filled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/delta-down-o.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/delta-left-o-filled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/delta-left-o.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/delta-right-o-filled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/delta-right-o.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/delta-up-o-filled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/delta-up-o.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/descending-filled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/descending.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/dialog-filled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/dialog.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/disallowance-filled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/disallowance.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/dot-chart-filled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/dot-chart.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/dot-ipv4-filled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/dot-ipv4.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/double-left-filled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/double-left.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/double-right-filled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/double-right.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/download-cloud-filled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/download-cloud.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/download-filled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/download.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/draw-flowchart-filled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/draw-flowchart.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/earth-lined-filled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/earth-lined.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/edit-filled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/edit.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/editor-align-center-filled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/editor-align-center.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/editor-align-left-filled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/editor-align-left.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/editor-align-right-filled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/editor-align-right.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/editor-bold-filled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/editor-bold.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/editor-code-filled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/editor-code.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/editor-deleteline-filled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/editor-deleteline.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/editor-eraser-filled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/editor-eraser.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/editor-italic-filled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/editor-italic.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/editor-left-border-filled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/editor-left-border.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/editor-list-dot-filled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/editor-list-dot.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/editor-list-num-filled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/editor-list-num.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/editor-menu-left-filled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/editor-menu-left.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/editor-menu-right-filled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/editor-menu-right.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/editor-quote-filled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/editor-quote.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/editor-redo-filled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/editor-redo.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/editor-right-border-filled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/editor-right-border.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/editor-sub-filled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/editor-sub.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/editor-subtitle-filled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/editor-subtitle.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/editor-super-filled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/editor-super.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/editor-table-filled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/editor-table.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/editor-textcolor-filled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/editor-textcolor.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/editor-title-filled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/editor-title.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/editor-underline-filled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/editor-underline.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/editor-undo-filled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/editor-undo.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/editor-video-filled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/editor-video.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/ellipsis-filled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/ellipsis.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/email-add-filled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/email-add.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/email-circle-filled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/email-circle.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/end-filled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/end.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/engine-workflow-filled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/engine-workflow.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/espace-auto-filled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/espace-auto.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/excel-type-filled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/excel-type.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/exception-filled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/exception.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/execution-phase-filled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/execution-phase.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/exhibition-forum-filled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/exhibition-forum.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/export-filled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/export.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/express-search-filled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/express-search.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/eyeclose-filled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/eyeclose.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/eyeopen-filled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/eyeopen.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/female-filled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/female.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/file-cloudupload-filled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/file-cloudupload.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/file-excel-filled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/file-excel.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/file-filled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/file-type-filled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/file-type.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/file.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/files-circle-filled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/files-circle.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/filetext-filled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/filetext.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/fileupload-filled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/fileupload.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/filtered-filled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/filtered.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/flag-filled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/flag.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/folder-closed-filled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/folder-closed.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/freeze-left-filled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/freeze-left.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/freeze-right-filled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/freeze-right.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/frown-o-filled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/frown-o.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/fullscreen-filled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/fullscreen-left-filled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/fullscreen-left.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/fullscreen.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/generating-filled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/generating.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/grade-filled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/grade.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/group-filled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/group-transfer-filled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/group-transfer.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/group.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/heartempty-filled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/heartempty.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/helpful-filled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/helpful.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/hot-cn-filled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/hot-cn.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/hot-en-filled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/hot-en.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/image-add-filled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/image-add.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/import-filled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/import.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/info-circle-filled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/info-circle.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/information-filled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/information.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/item-planning-properties-filled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/item-planning-properties.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/leave-filled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/leave.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/left-frozen-filled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/left-frozen.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/letter-filled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/letter.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/line-chart-filled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/line-chart.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/link-filled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/link.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/list-mode-filled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/list-mode.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/loading-filled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/loading.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/location-number-filled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/location-number.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/lock-filled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/lock.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/mail-content-filled.svgis excluded by!**/*.svgpackages/theme-saas/src/svgs/mail-content.svgis excluded by!**/*.svg
📒 Files selected for processing (1)
internals/automate/src/copy-svgs-raw/index.ts(1 hunks)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
兼容原有svg图标的行为。 如果用户不指定主副色属性，则在组件mounted时，移除所有fill属性
PR
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.