Skip to content

Conversation

@zzcr
Copy link
Member

@zzcr zzcr commented Nov 20, 2025

fix: 修复icon-multicolor构建失败问题

PR

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our Commit Message Guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Summary by CodeRabbit

  • Chores
    • Updated internal module import paths across the multicolor icon package to reflect directory structure adjustments. No changes to public APIs or component functionality—all exports and component behavior remain unchanged.

✏️ Tip: You can customize this high-level summary in your review settings.

@github-actions github-actions bot added the bug Something isn't working label Nov 20, 2025
@coderabbitai
Copy link

coderabbitai bot commented Nov 20, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

Adjusts relative import paths in 60+ multicolor icon modules from two-level-up (../../svgs/) to one-level-up (../svgs/), and updates the build configuration's sub-icon exclusion pattern from matching generic nested paths to specifically targeting TypeScript files in the src directory.

Changes

Cohort / File(s) Summary
Build configuration pattern update
internals/cli/src/commands/build/build-ui.ts
Modified sub-icon exclusion regex pattern from /vue-icon(-saas|-multicolor)?/.+ /index to /vue-icon(-saas|-multicolor)?/src/.+.ts to target TypeScript source files instead of generic index files.
Multicolor icon SVG import paths
packages/vue-icon-multicolor/src/*.ts (60 files)
Updated import paths for all icon components from ../../svgs/ to ../svgs/, including: activitys.ts, administrative-fees.ts, air-fares.ts, album-upload.ts, analysis-report.ts, analysis-report-1.ts, apply.ts, archives.ts, baggage-fees.ts, car-insurance.ts, car-rental.ts, case-study.ts, ceremony-fees.ts, condolences.ts, entertainment-expense.ts, expert-consultation-fees.ts, expert-reimburse-form.ts, expert-teaching-fees.ts, express-delivery.ts, ferry-fares.ts, file-upload.ts, fuel-cost.ts, gift-cost.ts, home-page.ts, housing-subsidy.ts, incidental-expenses.ts, landline-phone.ts, line-rental.ts, living-subsidy.ts, lodging-fees.ts, maintenance-service.ts, meal-allowance.ts, meal-subsidy.ts, meeting-expenses.ts, meeting-reimburse-form.ts, newspaper-subscription.ts, office-equipments.ts, office-supplies.ts, others.ts, phone-bills.ts, photo-identification.ts, physical-examination.ts, private-vehicle-allowance.ts, professional-terminology.ts, reception-reimburse-form.ts, reimbursement-form.ts, service-charges.ts, share-arrow.ts, ship.ts, taxi-fares.ts, train-fares.ts, training-fees.ts, training.ts, travel-application-form.ts, travel-expenses.ts, travel-order.ts, venue-hospitality-fees.ts, venue-rental-fees.ts, visa-fees.ts, white-pager.ts.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

  • The multicolor icon updates are homogeneous and repetitive (same path refactor across 60+ files), which significantly reduces review complexity
  • Focus verification on: (1) consistency of the path adjustment across all icon files, (2) the regex pattern change in the build configuration file to ensure it correctly targets TypeScript sources

Poem

🐰 Paths grow shorter, icons rise 🎨
From ../../ deep to ../ wise
Build configs dance with regex flair
Organized code floating in the air

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch zzc/fix-icon-saas-build-1120

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between dbb4267 and 536edec.

📒 Files selected for processing (61)
  • internals/cli/src/commands/build/build-ui.ts (1 hunks)
  • packages/vue-icon-multicolor/src/activitys.ts (1 hunks)
  • packages/vue-icon-multicolor/src/administrative-fees.ts (1 hunks)
  • packages/vue-icon-multicolor/src/air-fares.ts (1 hunks)
  • packages/vue-icon-multicolor/src/album-upload.ts (1 hunks)
  • packages/vue-icon-multicolor/src/analysis-report-1.ts (1 hunks)
  • packages/vue-icon-multicolor/src/analysis-report.ts (1 hunks)
  • packages/vue-icon-multicolor/src/apply.ts (1 hunks)
  • packages/vue-icon-multicolor/src/archives.ts (1 hunks)
  • packages/vue-icon-multicolor/src/baggage-fees.ts (1 hunks)
  • packages/vue-icon-multicolor/src/car-insurance.ts (1 hunks)
  • packages/vue-icon-multicolor/src/car-rental.ts (1 hunks)
  • packages/vue-icon-multicolor/src/case-study.ts (1 hunks)
  • packages/vue-icon-multicolor/src/ceremony-fees.ts (1 hunks)
  • packages/vue-icon-multicolor/src/condolences.ts (1 hunks)
  • packages/vue-icon-multicolor/src/entertainment-expense.ts (1 hunks)
  • packages/vue-icon-multicolor/src/expert-consultation-fees.ts (1 hunks)
  • packages/vue-icon-multicolor/src/expert-reimburse-form.ts (1 hunks)
  • packages/vue-icon-multicolor/src/expert-teaching-fees.ts (1 hunks)
  • packages/vue-icon-multicolor/src/express-delivery.ts (1 hunks)
  • packages/vue-icon-multicolor/src/ferry-fares.ts (1 hunks)
  • packages/vue-icon-multicolor/src/file-upload.ts (1 hunks)
  • packages/vue-icon-multicolor/src/fuel-cost.ts (1 hunks)
  • packages/vue-icon-multicolor/src/gift-cost.ts (1 hunks)
  • packages/vue-icon-multicolor/src/home-page.ts (1 hunks)
  • packages/vue-icon-multicolor/src/housing-subsidy.ts (1 hunks)
  • packages/vue-icon-multicolor/src/incidental-expenses.ts (1 hunks)
  • packages/vue-icon-multicolor/src/landline-phone.ts (1 hunks)
  • packages/vue-icon-multicolor/src/line-rental.ts (1 hunks)
  • packages/vue-icon-multicolor/src/living-subsidy.ts (1 hunks)
  • packages/vue-icon-multicolor/src/lodging-fees.ts (1 hunks)
  • packages/vue-icon-multicolor/src/maintenance-service.ts (1 hunks)
  • packages/vue-icon-multicolor/src/meal-allowance.ts (1 hunks)
  • packages/vue-icon-multicolor/src/meal-subsidy.ts (1 hunks)
  • packages/vue-icon-multicolor/src/meeting-expenses.ts (1 hunks)
  • packages/vue-icon-multicolor/src/meeting-reimburse-form.ts (1 hunks)
  • packages/vue-icon-multicolor/src/newspaper-subscription.ts (1 hunks)
  • packages/vue-icon-multicolor/src/office-equipments.ts (1 hunks)
  • packages/vue-icon-multicolor/src/office-supplies.ts (1 hunks)
  • packages/vue-icon-multicolor/src/others.ts (1 hunks)
  • packages/vue-icon-multicolor/src/phone-bills.ts (1 hunks)
  • packages/vue-icon-multicolor/src/photo-identification.ts (1 hunks)
  • packages/vue-icon-multicolor/src/physical-examination.ts (1 hunks)
  • packages/vue-icon-multicolor/src/private-vehicle-allowance.ts (1 hunks)
  • packages/vue-icon-multicolor/src/professional-terminology.ts (1 hunks)
  • packages/vue-icon-multicolor/src/reception-reimburse-form.ts (1 hunks)
  • packages/vue-icon-multicolor/src/reimbursement-form.ts (1 hunks)
  • packages/vue-icon-multicolor/src/service-charges.ts (1 hunks)
  • packages/vue-icon-multicolor/src/share-arrow.ts (1 hunks)
  • packages/vue-icon-multicolor/src/ship.ts (1 hunks)
  • packages/vue-icon-multicolor/src/taxi-fares.ts (1 hunks)
  • packages/vue-icon-multicolor/src/train-fares.ts (1 hunks)
  • packages/vue-icon-multicolor/src/training-fees.ts (1 hunks)
  • packages/vue-icon-multicolor/src/training.ts (1 hunks)
  • packages/vue-icon-multicolor/src/travel-application-form.ts (1 hunks)
  • packages/vue-icon-multicolor/src/travel-expenses.ts (1 hunks)
  • packages/vue-icon-multicolor/src/travel-order.ts (1 hunks)
  • packages/vue-icon-multicolor/src/venue-hospitality-fees.ts (1 hunks)
  • packages/vue-icon-multicolor/src/venue-rental-fees.ts (1 hunks)
  • packages/vue-icon-multicolor/src/visa-fees.ts (1 hunks)
  • packages/vue-icon-multicolor/src/white-pager.ts (1 hunks)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@zzcr zzcr merged commit 6f70737 into dev Nov 20, 2025
5 checks passed
@zzcr zzcr deleted the zzc/fix-icon-saas-build-1120 branch November 20, 2025 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants