Skip to content

Conversation

@krishagarwal278
Copy link
Member

Fixed Status capitalization issue so Status component can recognize icons

@openshift-ci-robot openshift-ci-robot added jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Dec 17, 2025
@openshift-ci-robot
Copy link
Contributor

@krishagarwal278: This pull request references Jira Issue OCPBUGS-69647, which is invalid:

  • expected the bug to target the "4.22.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Fixed Status capitalization issue so Status component can recognize icons

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@coderabbitai
Copy link

coderabbitai bot commented Dec 17, 2025

Walkthrough

Updated ConsoleOperatorConfig.tsx to render the ConsolePluginStatus value with its first character uppercased (e.g., "failed" → "Failed") while keeping the existing conditional errorMessage as the title when status is "failed". No public types or signatures changed.

Changes

Cohort / File(s) Summary
Status rendering enhancement
frontend/packages/console-app/src/components/console-operator/ConsoleOperatorConfig.tsx
Rendered ConsolePluginStatus by capitalizing the status string's first character; retained conditional errorMessage as the title when status equals "failed". No public API changes.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

  • Single-file, localized UI change with low logic density.
  • Review attention:
    • Verify casing across all possible status values and any downstream display/consumers.
    • Confirm errorMessage remains correctly applied as title when status is "failed".
    • Check for i18n/translation implications if status strings are localized.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Cache: Disabled due to data retention organization setting

Knowledge base: Disabled due to Reviews -> Disable Knowledge Base setting

📥 Commits

Reviewing files that changed from the base of the PR and between 58c1bf0 and e8500e7.

📒 Files selected for processing (1)
  • frontend/packages/console-app/src/components/console-operator/ConsoleOperatorConfig.tsx
🧰 Additional context used
📓 Path-based instructions (1)
**

⚙️ CodeRabbit configuration file

-Focus on major issues impacting performance, readability, maintainability and security. Avoid nitpicks and avoid verbosity.

Files:

  • frontend/packages/console-app/src/components/console-operator/ConsoleOperatorConfig.tsx
🔇 Additional comments (1)
frontend/packages/console-app/src/components/console-operator/ConsoleOperatorConfig.tsx (1)

91-96: LGTM! The capitalization fix correctly addresses the icon display issue.

The string manipulation safely transforms status values (e.g., "failed" → "Failed") for the Status component, and the conditional logic on line 94 correctly checks the original lowercase value. This aligns with the PR objective to fix missing icons in the Console plugins list table.

Verify that the status icons now display correctly in the Console plugins list table for all three states: "Pending", "Loaded", and "Failed".


Comment @coderabbitai help to get the list of available commands and usage tips.

@krishagarwal278
Copy link
Member Author

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Dec 17, 2025
@openshift-ci-robot
Copy link
Contributor

@krishagarwal278: This pull request references Jira Issue OCPBUGS-69647, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.22.0) matches configured target version for branch (4.22.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @yapei

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the component/core Related to console core functionality label Dec 17, 2025
Copy link
Member

@sg00dwin sg00dwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 17, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 17, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: krishagarwal278, logonoff, sg00dwin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 17, 2025
@krishagarwal278
Copy link
Member Author

/retest

2 similar comments
@krishagarwal278
Copy link
Member Author

/retest

@krishagarwal278
Copy link
Member Author

/retest

@rhamilto
Copy link
Member

/test e2e-gcp-console

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 22, 2025
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Dec 22, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 22, 2025

New changes are detected. LGTM label has been removed.

@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 22, 2025
@krishagarwal278
Copy link
Member Author

/retest

@krishagarwal278
Copy link
Member Author

/retest

1 similar comment
@krishagarwal278
Copy link
Member Author

/retest

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 23, 2025

@krishagarwal278: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gcp-console e8500e7 link true /test e2e-gcp-console
ci/prow/okd-scos-images e8500e7 link true /test okd-scos-images

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. component/core Related to console core functionality jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants