OCPBUGS-69379: pass filter text to filter handler

[yapei]

After:

after-fix.mov

[openshift-ci-robot]

@yapei: This pull request references Jira Issue OCPBUGS-69379, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.22.0) matches configured target version for branch (4.22.0)
• bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @yapei

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

After:

after-fix.mov

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

@openshift-ci-robot: GitHub didn't allow me to request PR reviews from the following users: yapei.

Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs.

Details

In response to this:

@yapei: This pull request references Jira Issue OCPBUGS-69379, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.22.0) matches configured target version for branch (4.22.0)
• bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @yapei

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

After:

after-fix.mov

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[coderabbitai]

Walkthrough

The TextFilter onChange handler in the role component was updated to pass the input value explicitly. The change extracts the value from the event object and passes it to the existing changeFilter method, changing from event object passing to string value passing for parameter alignment.

Changes

Cohort / File(s)	Change Summary
TextFilter Event Handler Update frontend/public/components/RBAC/role.jsx	Updated onChange handler to pass extracted input value (e.target.value) instead of event object, aligning with changeFilter method signature

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~5 minutes

• Area for attention: Verify that the changeFilter method accepts a string value and that the extracted value is used correctly downstream in the component logic.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Cache: Disabled due to data retention organization setting

Knowledge base: Disabled due to Reviews -> Disable Knowledge Base setting

📥 Commits

Reviewing files that changed from the base of the PR and between 4b8da82 and 909a9b0.

📒 Files selected for processing (1)

• frontend/public/components/RBAC/role.jsx (1 hunks)

🧰 Additional context used

📓 Path-based instructions (1)

**

⚙️ CodeRabbit configuration file

-Focus on major issues impacting performance, readability, maintainability and security. Avoid nitpicks and avoid verbosity.

Files:

• frontend/public/components/RBAC/role.jsx

🔇 Additional comments (1)

frontend/public/components/RBAC/role.jsx (1)

154-154: LGTM! Bug fix correctly aligns onChange with changeFilter signature.

The change correctly extracts the string value from the event before passing it to changeFilter, which expects a string parameter (line 91). Previously, passing the event object would have caused the fuzzy filter logic (lines 100-106) to fail since it operates on string values.

Please verify that the rules filtering now works correctly by testing the search functionality in the UI to ensure rules are properly filtered by action or resource.

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: yapei
Once this PR has been reviewed and has the lgtm label, please assign rawagner for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• frontend/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@yapei: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[yapei]

@jhadvig @krishagarwal278 could you please help take a look? Thanks!