OCPBUGS-68376: fix routing issues on packageserver PackageManifest de…

[rhamilto]

…tails page

[openshift-ci-robot]

@rhamilto: This pull request references Jira Issue OCPBUGS-68376, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.22.0) matches configured target version for branch (4.22.0)
• bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @yapei

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

…tails page

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[coderabbitai]

Walkthrough

Removed exact matching from two ClusterServiceVersion routes in console extensions and added a new Cypress integration test suite that validates PackageManifest tab rendering and navigation.

Changes

Cohort / File(s)	Summary
Route configuration frontend/packages/operator-lifecycle-manager/console-extensions.json	Removed the exact property from two console.page/route entries for ClusterServiceVersion-related paths; path arrays and component $codeRefs unchanged.
Integration tests (new) frontend/packages/operator-lifecycle-manager/integration-tests-cypress/tests/packageserver-tabs.cy.ts	Added a Cypress test file covering PackageManifest tabs: Details, YAML, Resources, Events, and navigation flow with URL and header assertions; includes global setup and error checks.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

• Pay attention to potential route collisions or broader matching effects after removing exact.
• Verify selectors and expected content in the new Cypress tests match current page structure and test fixtures.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Cache: Disabled due to data retention organization setting

Knowledge base: Disabled due to Reviews -> Disable Knowledge Base setting

📥 Commits

Reviewing files that changed from the base of the PR and between c8089ae and bc06080.

📒 Files selected for processing (2)

• frontend/packages/operator-lifecycle-manager/console-extensions.json (0 hunks)
• frontend/packages/operator-lifecycle-manager/integration-tests-cypress/tests/packageserver-tabs.cy.ts (1 hunks)

💤 Files with no reviewable changes (1)

• frontend/packages/operator-lifecycle-manager/console-extensions.json

🧰 Additional context used

📓 Path-based instructions (1)

**

⚙️ CodeRabbit configuration file

-Focus on major issues impacting performance, readability, maintainability and security. Avoid nitpicks and avoid verbosity.

Files:

• frontend/packages/operator-lifecycle-manager/integration-tests-cypress/tests/packageserver-tabs.cy.ts

🧬 Code graph analysis (1)

frontend/packages/operator-lifecycle-manager/integration-tests-cypress/tests/packageserver-tabs.cy.ts (2)

frontend/packages/integration-tests-cypress/support/index.ts (1)

• checkErrors (84-90)

frontend/packages/dev-console/integration-tests/support/pages/app.ts (1)

• yamlEditor (386-406)

🔇 Additional comments (7)

frontend/packages/operator-lifecycle-manager/integration-tests-cypress/tests/packageserver-tabs.cy.ts (7)

1-3: LGTM! Clean imports following Cypress conventions.

The imports are well-organized and use appropriate test utilities from the integration test support library.

---

20-32: LGTM! Well-structured Details tab test.

The test clearly verifies the key elements of the PackageManifest Details tab with appropriate assertions and helpful logging.

---

34-47: LGTM! YAML tab test correctly verifies editor content.

The test properly validates that the YAML editor loads and contains the expected PackageManifest metadata. The promise handling pattern at lines 43-46, while disabled from linting, is acceptable in Cypress's command chain context where errors are automatically caught by the test runner.

---

49-58: LGTM! Resources tab test is clear and appropriate.

The test correctly verifies the Resources tab loads and displays the empty state, which is expected for a PackageManifest.

---

60-69: LGTM! Events tab test follows consistent pattern.

The test appropriately verifies the Events tab loads and displays the expected empty state.

---

71-100: LGTM! Comprehensive navigation test with all concerns addressed.

The test thoroughly validates tab navigation and URL routing. The URL verification for the Events tab (line 90) addresses the previous review feedback. The test flow is logical and includes appropriate assertions at each step to verify both navigation and content loading.

---

8-8: The test assumes 3scale-operator is available in the cluster, but there is no visible setup that provisions this operator for the test suite. If this operator is not guaranteed to exist in all test environments, tests will fail unpredictably. Consider either parameterizing the operator name, using an operator that's guaranteed to be present (like packageserver which runs in openshift-operator-lifecycle-manager namespace), or explicitly documenting the prerequisite that 3scale-operator must be pre-deployed.

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Cache: Disabled due to data retention organization setting

Knowledge base: Disabled due to Reviews -> Disable Knowledge Base setting

📥 Commits

Reviewing files that changed from the base of the PR and between 336f9f8 and c8089ae.

📒 Files selected for processing (2)

• frontend/packages/operator-lifecycle-manager/console-extensions.json (0 hunks)
• frontend/packages/operator-lifecycle-manager/integration-tests-cypress/tests/packageserver-tabs.cy.ts (1 hunks)

💤 Files with no reviewable changes (1)

• frontend/packages/operator-lifecycle-manager/console-extensions.json

🧰 Additional context used

📓 Path-based instructions (1)

**

⚙️ CodeRabbit configuration file

-Focus on major issues impacting performance, readability, maintainability and security. Avoid nitpicks and avoid verbosity.

Files:

• frontend/packages/operator-lifecycle-manager/integration-tests-cypress/tests/packageserver-tabs.cy.ts

🧬 Code graph analysis (1)

frontend/packages/operator-lifecycle-manager/integration-tests-cypress/tests/packageserver-tabs.cy.ts (2)

frontend/packages/integration-tests-cypress/support/index.ts (1)

• checkErrors (84-90)

frontend/packages/dev-console/integration-tests/support/pages/app.ts (1)

• yamlEditor (386-406)

[rhamilto]

/cherrypick release-4.21

[openshift-cherrypick-robot]

@rhamilto: once the present PR merges, I will cherry-pick it on top of release-4.21 in a new PR and assign it to you.

Details

In response to this:

/cherrypick release-4.21

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[TheRealJon]

/lgtm

Thanks for the regression test too!

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhamilto, TheRealJon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• frontend/OWNERS [TheRealJon,rhamilto]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@rhamilto: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[rhamilto]

@yapei, can you please verify?

[yapei]

Confirmed tabs are loaded successfully and switching between tabs work
https://github.com/user-attachments/assets/9f8a8b26-46f0-43f0-a379-387dacc96ab8

/verified by @yapei

[openshift-ci-robot]

@yapei: This PR has been marked as verified by @yapei.

Details

In response to this:

Confirmed tabs are loaded successfully and switching between tabs work
https://github.com/user-attachments/assets/9f8a8b26-46f0-43f0-a379-387dacc96ab8

/verified by @yapei

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@rhamilto: Jira Issue Verification Checks: Jira Issue OCPBUGS-68376
✔️ This pull request was pre-merge verified.
✔️ All associated pull requests have merged.
✔️ All associated, merged pull requests were pre-merge verified.

Jira Issue OCPBUGS-68376 has been moved to the MODIFIED state and will move to the VERIFIED state when the change is available in an accepted nightly payload. 🕓

Details

In response to this:

…tails page

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-cherrypick-robot]

@rhamilto: new pull request created: #15873

Details

In response to this:

/cherrypick release-4.21

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[openshift-merge-robot]

Fix included in accepted release 4.22.0-0.nightly-2025-12-21-224908