Skip to content

Conversation

@cajieh
Copy link
Contributor

@cajieh cajieh commented Dec 5, 2025

Before:

Screenshot 2025-12-09 at 2 16 36 PM

After

Screenshot 2025-12-09 at 2 16 41 PM

@openshift-ci-robot openshift-ci-robot added jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. labels Dec 5, 2025
@openshift-ci-robot
Copy link
Contributor

@cajieh: This pull request references Jira Issue OCPBUGS-63237, which is invalid:

  • expected the bug to target the "4.21.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

/hold
Need to verify this change on AWS STS enabled cluster

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@coderabbitai
Copy link

coderabbitai bot commented Dec 5, 2025

Important

Review skipped

Auto reviews are limited based on label configuration.

🚫 Review skipped — only excluded labels are configured. (1)
  • do-not-merge/work-in-progress

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci-robot openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Dec 5, 2025
@openshift-ci openshift-ci bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Dec 5, 2025
@openshift-ci openshift-ci bot requested review from Leo6Leo and rhamilto December 5, 2025 17:29
@openshift-ci openshift-ci bot added component/olm Related to OLM approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Dec 5, 2025
@yanpzhan
Copy link
Contributor

yanpzhan commented Dec 8, 2025

Checked on sts cluster with the pr code, when operator annotations containing token-auth-aws/azure/gcp=false, on operator install page, there is not cloud credential related required field.
before:
Screenshot from 2025-12-08 16-02-56
after:
Screenshot from 2025-12-08 16-02-40
/verified by yanpzhan

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Dec 8, 2025
@openshift-ci-robot
Copy link
Contributor

@yanpzhan: This PR has been marked as verified by yanpzhan.

Details

In response to this:

Checked on sts cluster with the pr code, when operator annotations containing token-auth-aws/azure/gcp=false, on operator install page, there is not cloud credential related required field.
before:
Screenshot from 2025-12-08 16-02-56
after:
Screenshot from 2025-12-08 16-02-40
/verified by yanpzhan

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@Leo6Leo
Copy link
Contributor

Leo6Leo commented Dec 8, 2025

/retest-required

@cajieh cajieh force-pushed the not-show-arn-fields branch from 77d9a69 to f7af9ab Compare December 8, 2025 17:25
@openshift-ci-robot openshift-ci-robot removed the verified Signifies that the PR passed pre-merge verification criteria label Dec 8, 2025
@cajieh cajieh force-pushed the not-show-arn-fields branch 3 times, most recently from 06187ee to 6855351 Compare December 9, 2025 19:14
}).toString();
};
if (tokenizedAuth) {
installParams.tokenizedAuth = tokenizedAuth;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is not needed for the bug fix, but was added for consistency with the fix in useOperatorCatalogItems.tsx.

@openshift-ci-robot
Copy link
Contributor

@cajieh: This pull request references Jira Issue OCPBUGS-63237, which is invalid:

  • expected the bug to target the "4.21.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Before:

Screenshot 2025-12-09 at 2 16 36 PM

After

Screenshot 2025-12-09 at 2 16 41 PM

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@cajieh
Copy link
Contributor Author

cajieh commented Dec 11, 2025

/test backend

@cajieh cajieh force-pushed the not-show-arn-fields branch from 6855351 to ed4d16d Compare December 11, 2025 14:53
@cajieh cajieh changed the title [WIP] OCPBUGS-63237: There should be no role ARN field as token-auth-aws/azure/gcp=false in csv annotations OCPBUGS-63237: There should be no role ARN field as token-auth-aws/azure/gcp=false in csv annotations Dec 12, 2025
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 12, 2025
@Leo6Leo
Copy link
Contributor

Leo6Leo commented Dec 12, 2025

/retest-required

@cajieh
Copy link
Contributor Author

cajieh commented Dec 15, 2025

/test e2e-gcp-console

@cajieh
Copy link
Contributor Author

cajieh commented Dec 15, 2025

/jira refresh

@openshift-ci openshift-ci bot requested a review from yapei December 15, 2025 09:54
@cajieh
Copy link
Contributor Author

cajieh commented Dec 15, 2025

/verified later @yanpzhan
/label acknowledge-critical-fixes-only

@openshift-ci openshift-ci bot added the acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. label Dec 15, 2025
@openshift-ci-robot openshift-ci-robot added verified-later verified Signifies that the PR passed pre-merge verification criteria labels Dec 15, 2025
@openshift-ci-robot
Copy link
Contributor

@cajieh: This PR has been marked to be verified later by @yanpzhan.

Details

In response to this:

/verified later @yanpzhan
/label acknowledge-critical-fixes-only

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@cajieh
Copy link
Contributor Author

cajieh commented Dec 16, 2025

/test e2e-gcp-console

@jhadvig
Copy link
Member

jhadvig commented Dec 16, 2025

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 16, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 16, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cajieh, jhadvig

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cajieh
Copy link
Contributor Author

cajieh commented Dec 16, 2025

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 16, 2025
@cajieh
Copy link
Contributor Author

cajieh commented Dec 16, 2025

/retest

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 19b01f0 and 2 for PR HEAD ed4d16d in total

@cajieh
Copy link
Contributor Author

cajieh commented Dec 16, 2025

/retest

@lunarwhite
Copy link
Member

/test okd-scos-images

2 similar comments
@cajieh
Copy link
Contributor Author

cajieh commented Dec 17, 2025

/test okd-scos-images

@cajieh
Copy link
Contributor Author

cajieh commented Dec 17, 2025

/test okd-scos-images

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD 9ac9e36 and 1 for PR HEAD ed4d16d in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD d3b540a and 0 for PR HEAD ed4d16d in total

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 18, 2025

@cajieh: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit ec684cc into openshift:main Dec 19, 2025
8 checks passed
@openshift-ci-robot
Copy link
Contributor

@cajieh: Jira Issue OCPBUGS-63237: All pull requests linked via external trackers have merged:

This pull request has the verified-later tag and will need to be manually moved to VERIFIED after testing. Jira Issue OCPBUGS-63237 has been moved to the MODIFIED state.

Details

In response to this:

Before:

Screenshot 2025-12-09 at 2 16 36 PM

After

Screenshot 2025-12-09 at 2 16 41 PM

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-cherrypick-robot

@cajieh: new pull request created: #15869

Details

In response to this:

/cherry-pick release-4.20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@cajieh
Copy link
Contributor Author

cajieh commented Dec 19, 2025

/cherry-pick release-4.21

@openshift-cherrypick-robot

@cajieh: new pull request created: #15870

Details

In response to this:

/cherry-pick release-4.21

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-merge-robot
Copy link
Contributor

Fix included in accepted release 4.22.0-0.nightly-2025-12-21-224908

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

acknowledge-critical-fixes-only Indicates if the issuer of the label is OK with the policy. approved Indicates a PR has been approved by an approver from all required OWNERS files. component/olm Related to OLM jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria verified-later

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants