Skip to content

OCPBUGS-55425: README and Makefile improvements #982

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Mylanos wants to merge 3 commits into
base: main
Choose a base branch
from
Open

OCPBUGS-55425: README and Makefile improvements #982

Mylanos wants to merge 3 commits into from

Conversation

@Mylanos
Copy link

@Mylanos Mylanos commented Apr 28, 2025

No description provided.

@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Apr 28, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Apr 28, 2025

@Mylanos: This pull request references Jira Issue OCPBUGS-55425, which is invalid:

  • expected the bug to target the "4.19.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from TheRealJon and jhadvig April 28, 2025 14:05
Mylanos
Mylanos commented Apr 28, 2025
View reviewed changes
Mylanos
Mylanos commented Apr 28, 2025
View reviewed changes
@Mylanos
Copy link
Author

Mylanos commented Jun 10, 2025

/retest

@Leo6Leo Leo6Leo mentioned this pull request Jul 3, 2025
Closed
jhadvig
jhadvig approved these changes Jul 22, 2025
View reviewed changes
Copy link
Member

@jhadvig jhadvig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@jhadvig
Copy link
Member

jhadvig commented Jul 22, 2025

/retest

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 22, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 22, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jhadvig, Mylanos

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 22, 2025
@Mylanos
Copy link
Author

Mylanos commented Aug 14, 2025

/retest

Mylanos added 2 commits August 14, 2025 13:41
@Mylanos
OCPBUGS-55425: Make the description for the docker build up to date w…
76a5029 
…ith up to date files, update the file name of the example CO manifest referenced in the how to steps
@Mylanos
add vendor Makefile rule
29d3072
@Mylanos Mylanos force-pushed the OCPBUGS-55425-improvements-readme-makefile branch from e3c3bd3 to 7ec76f0 Compare August 14, 2025 12:53
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Aug 14, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 14, 2025

New changes are detected. LGTM label has been removed.

@Mylanos Mylanos force-pushed the OCPBUGS-55425-improvements-readme-makefile branch from 7ec76f0 to 7fd4ec6 Compare August 14, 2025 14:21
@Mylanos
Copy link
Author

Mylanos commented Aug 25, 2025

/retest

1 similar comment
@Mylanos
Copy link
Author

Mylanos commented Aug 25, 2025

/retest

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 25, 2025

@Mylanos: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-bot
Copy link
Contributor

openshift-bot commented Nov 24, 2025

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 24, 2025
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 24, 2025
@openshift-merge-robot
Copy link
Contributor

openshift-merge-robot commented Nov 24, 2025

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-bot
Copy link
Contributor

openshift-bot commented Dec 24, 2025

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

@openshift-ci openshift-ci bot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Dec 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jhadvig jhadvig jhadvig approved these changes

@TheRealJon TheRealJon Awaiting requested review from TheRealJon

Assignees

@jhadvig jhadvig

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Mylanos @openshift-ci-robot @jhadvig @openshift-bot @openshift-merge-robot