Skip to content

Add visual indicator for sensitive actions #1736

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rSnapkoOpenOps merged 5 commits into from
Dec 9, 2025
Merged

Add visual indicator for sensitive actions #1736

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
a7d94de
Add visual indicator for sensitive actions
rSnapkoOpenOps Dec 5, 2025
f0cf80b
Merge branch 'main' into feat/add-visual-indicator-for-sensitive-actions
rSnapkoOpenOps Dec 5, 2025
84bdedd
chore
rSnapkoOpenOps Dec 5, 2025
997d492
Refactor action metadata logic to centralize in flows-utils and repla…
rSnapkoOpenOps Dec 8, 2025
b2906bd
fix: lint
rSnapkoOpenOps Dec 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
97 changes: 72 additions & 25 deletions packages/react-ui/src/app/features/builder/flow-canvas/nodes/step-node.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,9 +32,12 @@ import {
FlowRunStatus,
FlowVersion,
isNil,
RiskLevel,
TriggerType,
} from '@openops/shared';

import { getActionMetadata } from '@/app/features/flows/components/execute-risky-flow-dialog/utils';
import { ShieldHalf } from 'lucide-react';
import { CanvasContextMenu } from '../context-menu/canvas-context-menu';
import { CollapsibleButton } from './collapsible-button';
import { StackedNodeLayers } from './stacked-node-layer';
Expand Down Expand Up @@ -86,6 +89,11 @@ const WorkflowStepNode = React.memo(
step: data.step!,
});

const { metadata: actionsMetadata } = blocksHooks.useAllStepsMetadata({
searchQuery: '',
type: 'action',
});

const stepIndex = useMemo(() => {
const steps = flowHelper.getAllSteps(flowVersion.trigger);
return steps.findIndex((step) => step.name === data.step!.name) + 1;
Expand Down Expand Up @@ -122,6 +130,27 @@ const WorkflowStepNode = React.memo(
return getStepStatus(data.step?.name, run, loopIndexes, flowVersion);
}, [data.step?.name, run, loopIndexes, flowVersion]);

const isRiskyStep = useMemo(() => {
const actionName = data.step?.settings.actionName;
const blockName = data.step?.settings.blockName;

if (!actionsMetadata || !actionName || !blockName) {
return false;
}

const actionMetadata = getActionMetadata(
actionsMetadata,
blockName,
actionName,
);

return actionMetadata?.riskLevel === RiskLevel.HIGH;
Copy link
Contributor

@alexandrudanpop alexandrudanpop Dec 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would be cool to have this logic extracted from the component

Copy link
Contributor

@cezudas cezudas Dec 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, a custom hook placed outside this module would make mocking this dependency very convenient in case we add unit/sb tests in the future.

}, [
actionsMetadata,
data.step?.settings.actionName,
data.step?.settings.blockName,
]);

const showRunningIcon =
isNil(stepOutputStatus) && run?.status === FlowRunStatus.RUNNING;
const statusInfo = isNil(stepOutputStatus)
Expand Down Expand Up @@ -247,15 +276,49 @@ const WorkflowStepNode = React.memo(
</div>
</div>

{!readonly && (
<CanvasContextMenu
data={data}
isAction={isAction}
openStepActionsMenu={openStepActionsMenu}
setOpenStepActionsMenu={setOpenStepActionsMenu}
setOpenBlockSelector={setOpenBlockSelector}
/>
)}
<div className="flex items-center gap-0.5">
<div className="flex items-center gap-[7px]">
{!data.step?.valid && (
<Tooltip>
<TooltipTrigger asChild>
<InvalidStepIcon
size={16}
viewBox="0 0 16 16"
className="stroke-0 animate-fade"
></InvalidStepIcon>
</TooltipTrigger>
<TooltipContent side="bottom">
{t('Incomplete settings')}
</TooltipContent>
</Tooltip>
)}

{isRiskyStep && (
<Tooltip>
<TooltipTrigger asChild>
<div className="size-4 flex items-center justify-center rounded-full bg-destructive-100">
<ShieldHalf className="size-[10px] text-destructive-300"></ShieldHalf>
</div>
</TooltipTrigger>
<TooltipContent side="bottom">
{t(
'This step may make changes to your environment',
)}
</TooltipContent>
</Tooltip>
)}
</div>

{!readonly && (
<CanvasContextMenu
data={data}
isAction={isAction}
openStepActionsMenu={openStepActionsMenu}
setOpenStepActionsMenu={setOpenStepActionsMenu}
setOpenBlockSelector={setOpenBlockSelector}
/>
)}
</div>
</div>

<div className="flex justify-between gap-[6px] w-full items-center">
Expand All @@ -276,22 +339,6 @@ const WorkflowStepNode = React.memo(
{showRunningIcon && (
<LoadingSpinner className="w-4 h-4 text-primary"></LoadingSpinner>
)}
{!data.step?.valid && (
<Tooltip>
<TooltipTrigger asChild>
<div className="mr-2">
<InvalidStepIcon
size={16}
viewBox="0 0 16 16"
className="stroke-0 animate-fade"
></InvalidStepIcon>
</div>
</TooltipTrigger>
<TooltipContent side="bottom">
{t('Incomplete settings')}
</TooltipContent>
</Tooltip>
)}
</div>
</div>
</div>
Expand Down
2 changes: 1 addition & 1 deletion packages/react-ui/src/app/features/flows/components/execute-risky-flow-dialog/utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import { Action, ActionType, RiskLevel, Trigger } from '@openops/shared';

type ActionOrTriggerWithIndex = (Action | Trigger) & { index: number };

const getActionMetadata = (
export const getActionMetadata = (
metadata: StepMetadataWithSuggestions[] | undefined,
blockName: string,
actionName: string | undefined,
Expand Down
Loading