-
Notifications
You must be signed in to change notification settings - Fork 180
refactor: minor updates #634
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||||||||
commit: |
conico974
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a little comment, other than that LGTM
| return; | ||
| if (f !== "server.js") { | ||
| readdirSync(path.join(standaloneNextDir, "server")) | ||
| .filter( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could do it in 1 filter instead of 2, it avoids having to iterate over everything twice
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes we could.
however I like to have "simple" filters.
I don't think the time lost iterating a list is significant vs i/o (copy the files).
Happy to change if you feel strongly about this one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok fine for me then, i don't have that strong of an opinion on this
No description provided.